Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

Hi Emil, Sorry for late reply. I was so busy last week and this week. Your logic looks correct, smarter and shorter. I feel relatively more difficult to understand the logic, with two "!" and one "||" in the same if statement. Thanks for the advice always. On 2017-07-20 02:29 PM, Emil

Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

Hi Alex, On 20 July 2017 at 03:46, Alex Xie wrote: > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c > @@ -198,12 +198,18 @@ amdgpu_bo_list_get(struct amdgpu_fpriv *fpriv, int id) > result =

Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

Yeah, with the coding style fixed Reviewed-by: Christian König as well. Christian. Am 20.07.2017 um 05:01 schrieb zhoucm1: one small nit pick, with that fix, Reviewed-by: Chunming Zhou On 2017年07月20日 10:46, Alex Xie wrote: In RCU read-side

Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

one small nit pick, with that fix, Reviewed-by: Chunming Zhou On 2017年07月20日 10:46, Alex Xie wrote: In RCU read-side critical sections, blocking or sleeping is prohibited. v2: Unlock RCU for the code path where result==NULL. (David Zhou) Update subject Tested-by

[PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

In RCU read-side critical sections, blocking or sleeping is prohibited. v2: Unlock RCU for the code path where result==NULL. (David Zhou) Update subject Tested-by and reported by: Dave Airlie [ 141.965723] = [ 141.965724] WARNING: