Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-25 Thread Deucher, Alexander
Cc: Zeng, Oak Subject: Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file Did you see my other comments about consolidating vega10, raven, and vega12? Reviewed-by: Alex Deucher mailto:alexander.deuc...@amd.com>> From: amd-gfx mailto:a

RE: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Zeng, Oak
on behalf of Oak Zeng mailto:oz...@amd.com>> Sent: Friday, November 23, 2018 3:01:23 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file Move doorbell structures, enum definitions and

Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Deucher, Alexander
: Moved doorbell structures to seperate file Move doorbell structures, enum definitions and helper functions from amdgpu.h to amdgpu_doorbell.h. No functional change Change-Id: I09f7b84869b6d3c688b7a2506ff78d62b3de23f5 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 227

RE: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Zeng, Oak
Hi Alex, This is a follow up patch to your previous comment on the doorbell patches. Please review. Regards, Oak -Original Message- From: Zeng, Oak Sent: Friday, November 23, 2018 3:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu: Moved doorbell

[PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Oak Zeng
Move doorbell structures, enum definitions and helper functions from amdgpu.h to amdgpu_doorbell.h. No functional change Change-Id: I09f7b84869b6d3c688b7a2506ff78d62b3de23f5 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 227 +--- drivers/gpu/drm/a