Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 for GFX10

2019-08-14 Thread Christian König
Am 13.08.19 um 20:43 schrieb Zhao, Yong: We have done this for pre-GFX10 asics, but GFX10 did not pick up the new change. The below is the commit message for that change. This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMI

[PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 for GFX10

2019-08-13 Thread Zhao, Yong
We have done this for pre-GFX10 asics, but GFX10 did not pick up the new change. The below is the commit message for that change. This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMISSION_OR_INVALID_PAGE_FAULT rather than usu

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-27 Thread Zhao, Yong
Pushed. Thanks. Yong From: Alex Deucher Sent: Tuesday, February 26, 2019 10:53 PM To: Zhao, Yong Cc: Koenig, Christian; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 yes, go ahead. Alex On Tue, Feb

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Alex Deucher
yes, go ahead. Alex On Tue, Feb 26, 2019 at 6:18 PM Zhao, Yong wrote: > > So can I submit it only with the ACKs? > > Yong > > On 2019-02-26 5:29 a.m., Christian König wrote: > > Am 26.02.19 um 00:03 schrieb Zhao, Yong: > >> This is recommended by HW designers. Previously when it was set to 1, >

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Zhao, Yong
So can I submit it only with the ACKs? Yong On 2019-02-26 5:29 a.m., Christian König wrote: > Am 26.02.19 um 00:03 schrieb Zhao, Yong: >> This is recommended by HW designers. Previously when it was set to 1, >> the PDE walk error in VM fault will be treated as >> PERMISSION_OR_INVALID_PAGE_FAULT

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Christian König
ucher; Zhao, Yong Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 Don't we want PDE faults to be treated the same way as page faults? Or am I misinterpreting the commit message? Thanks, John Original Message From: Alex Deucher Sent: Monday

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-26 Thread Christian König
Am 26.02.19 um 00:03 schrieb Zhao, Yong: This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMISSION_OR_INVALID_PAGE_FAULT rather than usually expected OTHER_FAULT. As a result, the retry control in VM_CONTEXT*_CNTL will chang

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-25 Thread Bridgman, John
25, 2019 22:46 To: Alex Deucher; Zhao, Yong Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 Don't we want PDE faults to be treated the same way as page faults? Or am I misinterpreting the commit message? Thanks, John Original Message From:

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-25 Thread Bridgman, John
Don't we want PDE faults to be treated the same way as page faults? Or am I misinterpreting the commit message? Thanks, John Original Message From: Alex Deucher Sent: Monday, February 25, 2019 21:53 To: Zhao, Yong Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-25 Thread Alex Deucher
On Mon, Feb 25, 2019 at 6:03 PM Zhao, Yong wrote: > > This is recommended by HW designers. Previously when it was set to 1, > the PDE walk error in VM fault will be treated as > PERMISSION_OR_INVALID_PAGE_FAULT rather than usually expected OTHER_FAULT. > As a result, the retry control in VM_CONTEX

[PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-25 Thread Zhao, Yong
This is recommended by HW designers. Previously when it was set to 1, the PDE walk error in VM fault will be treated as PERMISSION_OR_INVALID_PAGE_FAULT rather than usually expected OTHER_FAULT. As a result, the retry control in VM_CONTEXT*_CNTL will change accordingly. The above behavior is kind