RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-04 Thread Clements, John
, 2021 10:07 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Li, Candice ; Lazar, Lijo Subject: Re: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access Hello Guchun, In most of those cases you are right it is redundant, the reason i kept them separate f

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-04 Thread Chen, Guchun
ailto:candice...@amd.com>>; Lazar, Lijo mailto:lijo.la...@amd.com>> Subject: Re: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access Hello Guchun, In most of those cases you are right it is redundant, the reason i kept them separate for now is to resolve this bug while also ke

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-03 Thread Chen, Guchun
: RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access [Public] @Chen, Guchun<mailto:guchun.c...@amd.com>, Based off your feedback I double checked the code, and I changed my opinion about it, I think it's better just to reuse the original mutex for now. I've submitted an u

Re: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-03 Thread Clements, John
: Zhang, Hawking ; Li, Candice ; Lazar, Lijo Subject: RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access [Public] Before calling into psp_cmd_submit_buf, a mutex psp->cmd_buf_mutex is there, and after entering psp_cmd_submit_buf, there is another mutex psp->mutex, is it

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-03 Thread Chen, Guchun
op.org Cc: Zhang, Hawking ; Li, Candice ; Lazar, Lijo ; Chen, Guchun Subject: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access [AMD Official Use Only] Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions.

[PATCH] drm/amdgpu: added synchronization for psp cmd buf access

2021-08-03 Thread Clements, John
[AMD Official Use Only] Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions. 0001-drm-amdgpu-added-synchronization-for-psp-cmd-buf-acc.patch Description: 0001-drm-amdgpu-added-synchronization-for-psp-cmd-buf-acc.patch