Re: [PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

2018-05-30 Thread Huang Rui
On Tue, May 29, 2018 at 06:17:59PM +0800, Evan Quan wrote: > Change-Id: Id7dcf60acf524f290460d2ffe3f1f5f46354 Need a commit log even it is very short. > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletion

Re: [PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

2018-05-30 Thread Christian König
WARN_ON is more appropriate. Regards, Christian. Regards, Evan -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Tuesday, May 29, 2018 11:50 PM To: Quan, Evan Cc: amd-gfx list ; Deucher, Alexander ; Huang, Ray Subject: Re: [PATCH] drm/amdgpu: detect buffer

RE: [PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

2018-05-29 Thread Quan, Evan
-Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, May 29, 2018 11:50 PM > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Huang, Ray > Subject: Re: [PATCH] drm/amdgpu: detect buffer overflow and avoid > unnecessary dereferenc

Re: [PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

2018-05-29 Thread Alex Deucher
On Tue, May 29, 2018 at 6:17 AM, Evan Quan wrote: > Change-Id: Id7dcf60acf524f290460d2ffe3f1f5f46354 > Signed-off-by: Evan Quan Please include a patch description as well. One comment below. > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +-- > 1 file changed, 9 insertions

[PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

2018-05-29 Thread Evan Quan
Change-Id: Id7dcf60acf524f290460d2ffe3f1f5f46354 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 7c5a850.