回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Liu, Monk
Isn't from me... damn keyboard -邮件原件- 发件人: amd-gfx 代表 Liu, Monk 发送时间: 2020年2月20日 23:24 收件人: Das, Nirmoy ; amd-gfx@lists.freedesktop.org 主题: 回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference I don't know The patch is from me, I just think the patch is dropping a vm update

回复: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Liu, Monk
I don't know The patch is from me, I just think the patch is dropping a vm update which looks not perfect to me -邮件原件- 发件人: amd-gfx 代表 Nirmoy 发送时间: 2020年2月20日 23:21 收件人: amd-gfx@lists.freedesktop.org 主题: Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference Hi Monk, How  can

Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Nirmoy
Hi Monk, How  can I reproduce this bug ? Regards, Nirmoy On 2/20/20 4:15 PM, Nirmoy wrote: On 2/20/20 2:35 PM, Liu, Monk wrote: Sorry, my previous idea still leave RQ null, please check if below method works: 29 static struct drm_sched_rq * 130 drm_sched_entity_get_free_sched(struct

Re: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Nirmoy
On 2/20/20 2:35 PM, Liu, Monk wrote: Sorry, my previous idea still leave RQ null, please check if below method works: 29 static struct drm_sched_rq * 130 drm_sched_entity_get_free_sched(struct drm_sched_entity *entity) 131 { 132 struct drm_sched_rq *rq = NULL; 133 unsigned int

回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Liu, Monk
Dennis ; Koenig, Christian ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Chen, Guchun 主题: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference so the scenario is: KMD doing page update -> ECC -> baco reset (mute SDMA scheduler) -> drm_sched_entity_ge

回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Liu, Monk
; Zhou1, Tao ; Chen, Guchun 主题: RE: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference [AMD Official Use Only - Internal Distribution Only] Hi, Christian and Monk, When doing SDMA copy, a RAS uncorrectable error happens, which will cause this issue. The RAS uncorrectable error event will

Re: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Nirmoy
st Regards Dennis Li -Original Message- From: Liu, Monk Sent: Wednesday, February 19, 2020 7:30 PM To: Koenig, Christian ; Zhang, Hawking ; Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Chen, Guchun Subject: 回复: [PATCH] drm/amdgpu: fix a bug NULL poi

RE: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-20 Thread Li, Dennis
amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Chen, Guchun Subject: 回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference > + if (!entity->rq) > + return 0; > + Yes, supposedly we shouldn't get 'entity->rq == NULL' case , that looks the tr

回复: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-19 Thread Liu, Monk
op.org; Deucher, Alexander ; Zhou1, Tao ; Chen, Guchun 主题: Re: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference Well of hand this patch looks like a clear NAK to me. Returning without raising an error is certainly the wrong thing to do here because we just drop the necessary page table upd

Re: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-19 Thread Christian König
hen, Guchun Cc: Li, Dennis Subject: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference check whether the queue of entity is null to avoid null pointer dereference. Change-Id: I08d56774012cf229ba2fe7a011c1359e8d1e2781 Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amd

RE: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-18 Thread Zhang, Hawking
, Dennis Subject: [PATCH] drm/amdgpu: fix a bug NULL pointer dereference check whether the queue of entity is null to avoid null pointer dereference. Change-Id: I08d56774012cf229ba2fe7a011c1359e8d1e2781 Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu

[PATCH] drm/amdgpu: fix a bug NULL pointer dereference

2020-02-18 Thread Dennis Li
check whether the queue of entity is null to avoid null pointer dereference. Change-Id: I08d56774012cf229ba2fe7a011c1359e8d1e2781 Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c index 4cc7881f438c..67cca463ddcc