Re: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently

2018-10-22 Thread Koenig, Christian
Mhm, good catch. And yes using the paging queue when it is available sounds like a good idea to me as well. So far I've only used it for VM updates to actually test if it works as expected. Regards, Christian. Am 19.10.18 um 21:53 schrieb Kuehling, Felix: > [+Christian] > > Should the buffer

Re: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently

2018-10-19 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yang, Philip Sent: Friday, October 19, 2018 3:13:56 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently For sdma v4, there is bug

Re: [PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently

2018-10-19 Thread Kuehling, Felix
[+Christian] Should the buffer funcs also use the paging ring? I think that would be important for being able to clear page tables or migrating a BO while handling a page fault. Regards,   Felix On 2018-10-19 3:13 p.m., Yang, Philip wrote: > For sdma v4, there is bug caused by > commit

[PATCH] drm/amdgpu: fix sdma v4 ring is disabled accidently

2018-10-19 Thread Yang, Philip
For sdma v4, there is bug caused by commit d4e869b6b5d6 ("drm/amdgpu: add ring test for page queue")' local variable ring is reused and changed, so amdgpu_ttm_set_buffer_funcs_status(adev, true) is skipped accidently. As a result, amdgpu_fill_buffer() will fail, kernel message: