Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-12 Thread Christian König
Am 10.01.23 um 19:21 schrieb Mikhail Gavrilov: On Mon, Jan 9, 2023 at 6:40 PM Christian König wrote: That looks like an out of memory situation is not gracefully handled. In other words we have a missing NULL check in drm_sched_job_cleanup(). Going to take a look. Very strange because it

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-09 Thread Christian König
Am 09.01.23 um 14:13 schrieb Mikhail Gavrilov: On Fri, Jan 6, 2023 at 8:27 PM Christian König wrote: And it looks like Dmitry submitted it initially to the wrong branch. Because of this it wasn't scheduled as fix for 6.2, but rather queued up as new feature for 6.3. This is fixed by now and

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-06 Thread Christian König
Am 06.01.23 um 15:24 schrieb Alex Deucher: On Fri, Jan 6, 2023 at 8:00 AM Mikhail Gavrilov wrote: On Thu, Jan 5, 2023 at 3:03 PM Christian König wrote: That one should be fixed by: commit 9f1ecfc5dcb47a7ca37be47b0eaca0f37f1ae93d Author: Dmitry Osipenko Date: Wed Nov 23 03:13:03 2022 +0300

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-06 Thread Alex Deucher
On Fri, Jan 6, 2023 at 8:00 AM Mikhail Gavrilov wrote: > > On Thu, Jan 5, 2023 at 3:03 PM Christian König > wrote: > > > > That one should be fixed by: > > > > commit 9f1ecfc5dcb47a7ca37be47b0eaca0f37f1ae93d > > Author: Dmitry Osipenko > > Date: Wed Nov 23 03:13:03 2022 +0300 > > > > Christian

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-06 Thread Mikhail Gavrilov
On Thu, Jan 5, 2023 at 3:03 PM Christian König wrote: > > That one should be fixed by: > > commit 9f1ecfc5dcb47a7ca37be47b0eaca0f37f1ae93d > Author: Dmitry Osipenko > Date: Wed Nov 23 03:13:03 2022 +0300 > Christian, This patch was written Nov. 23, 2022, but still not submitted in 6.2! Why? It

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-05 Thread Christian König
Am 05.01.23 um 02:44 schrieb Mikhail Gavrilov: On Tue, Jan 3, 2023 at 7:26 PM Alex Deucher wrote: On Tue, Jan 3, 2023 at 3:34 AM Christian König wrote: I assume that this was already upstreamed while I was on sick leave? Yes. Alex What about commit 2fdb8a8f07c2f1353770a324fd19b8114e4329ac

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-03 Thread Michel Dänzer
On 1/3/23 15:26, Alex Deucher wrote: > On Tue, Jan 3, 2023 at 3:34 AM Christian König > wrote: >> >> I assume that this was already upstreamed while I was on sick leave? > > Yes. Though there seem to be more issues still, see comments on https://gitlab.freedesktop.org/drm/amd/-/issues/2309 .

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-03 Thread Alex Deucher
On Tue, Jan 3, 2023 at 3:34 AM Christian König wrote: > > I assume that this was already upstreamed while I was on sick leave? Yes. Alex > > Thanks, > Christian. > > Am 21.12.22 um 22:10 schrieb Alex Deucher: > > Applied. Thanks! > > > > Alex > > > > On Mon, Dec 19, 2022 at 3:01 PM Borislav P

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2023-01-03 Thread Christian König
I assume that this was already upstreamed while I was on sick leave? Thanks, Christian. Am 21.12.22 um 22:10 schrieb Alex Deucher: Applied. Thanks! Alex On Mon, Dec 19, 2022 at 3:01 PM Borislav Petkov wrote: On Mon, Dec 19, 2022 at 11:47:18AM +0100, Christian König wrote: That function co

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2022-12-23 Thread Michal Kubecek
On Mon, Dec 19, 2022 at 11:47:18AM +0100, Christian König wrote: > That function consumes the reference. > > Signed-off-by: Christian König > Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies for VM updates") Tested-by: Michal Kubecek I can still see weird artefacts in some windows

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2022-12-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Dec 19, 2022 at 3:01 PM Borislav Petkov wrote: > > On Mon, Dec 19, 2022 at 11:47:18AM +0100, Christian König wrote: > > That function consumes the reference. > > > > Signed-off-by: Christian König > > Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies fo

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2022-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2022 at 11:47:18AM +0100, Christian König wrote: > That function consumes the reference. > > Signed-off-by: Christian König > Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies for VM updates") > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 2 ++ > 1 file changed

Re: [PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2022-12-19 Thread Luben Tuikov
Reviewed-by: Luben Tuikov Regards, Luben On 2022-12-19 05:47, Christian König wrote: > That function consumes the reference. > > Signed-off-by: Christian König > Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies for VM updates") > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c |

[PATCH] drm/amdgpu: grab extra fence reference for drm_sched_job_add_dependency

2022-12-19 Thread Christian König
That function consumes the reference. Signed-off-by: Christian König Fixes: aab9cf7b6954 ("drm/amdgpu: use scheduler dependencies for VM updates") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/