Re: [PATCH] drm/amdgpu: implement TMZ accessor (v3)

2019-12-02 Thread Alex Deucher
On Wed, Nov 27, 2019 at 6:36 PM Luben Tuikov wrote: > > Implement an accessor of adev->tmz.enabled. Let not > code around access it as "if (adev->tmz.enabled)" > as the organization may change. Instead... > > Recruit "bool amdgpu_is_tmz(adev)" to return > exactly this Boolean value. That is, this

[PATCH] drm/amdgpu: implement TMZ accessor (v3)

2019-11-27 Thread Luben Tuikov
Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(adev)" to return exactly this Boolean value. That is, this function is now an accessor of an already initialized and set

Re: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-27 Thread Luben Tuikov
On 2019-11-27 3:37 p.m., Alex Deucher wrote: > On Tue, Nov 26, 2019 at 9:03 PM Luben Tuikov wrote: >> >> Implement an accessor of adev->tmz.enabled. Let not >> code around access it as "if (adev->tmz.enabled)" >> as the organization may change. Instead... >> >> Recruit "bool amdgpu_is_tmz(adev)"

Re: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-27 Thread Alex Deucher
On Tue, Nov 26, 2019 at 9:03 PM Luben Tuikov wrote: > > Implement an accessor of adev->tmz.enabled. Let not > code around access it as "if (adev->tmz.enabled)" > as the organization may change. Instead... > > Recruit "bool amdgpu_is_tmz(adev)" to return > exactly this Boolean value. That is, this

[PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-26 Thread Luben Tuikov
Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(adev)" to return exactly this Boolean value. That is, this function is now an accessor of an already initialized and set

Re: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-26 Thread Christian König
, Alexander ; Tuikov, Luben ; Koenig, Christian Subject: [PATCH] drm/amdgpu: implement TMZ accessor (v2) Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(ade

Re: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-20 Thread Luben Tuikov
p.org >>> Cc: Deucher, Alexander ; Tuikov, Luben >>> ; Koenig, Christian >>> Subject: [PATCH] drm/amdgpu: implement TMZ accessor (v2) >>> >>> Implement an accessor of adev->tmz.enabled. Let not code around access it >>> as "if (adev->

Re: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-20 Thread Luben Tuikov
Koenig, Christian >> Subject: [PATCH] drm/amdgpu: implement TMZ accessor (v2) >> >> Implement an accessor of adev->tmz.enabled. Let not code around access it >> as "if (adev->tmz.enabled)" >> as the organization may change. Instead... >> >> Recru

RE: [PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-20 Thread Liu, Aaron
> -Original Message- > From: amd-gfx On Behalf Of > Luben Tuikov > Sent: Thursday, November 21, 2019 9:33 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Tuikov, Luben > ; Koenig, Christian > Subject: [PATCH] drm/amdgpu: implement TMZ acce

[PATCH] drm/amdgpu: implement TMZ accessor (v2)

2019-11-20 Thread Luben Tuikov
Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(adev)" to return exactly this Boolean value. That is, this function is now an accessor of an already initialized and set

Re: [PATCH] drm/amdgpu: implement TMZ accessor

2019-11-03 Thread Christian König
Am 01.11.19 um 19:24 schrieb Tuikov, Luben: On 2019-11-01 14:14, Alex Deucher wrote: On Thu, Oct 31, 2019 at 8:15 PM Tuikov, Luben wrote: On 2019-10-31 3:29 a.m., Christian König wrote: Am 31.10.19 um 00:43 schrieb Tuikov, Luben: Implement an accessor of adev->tmz.enabled. Let not code

Re: [PATCH] drm/amdgpu: implement TMZ accessor

2019-11-01 Thread Tuikov, Luben
On 2019-11-01 14:14, Alex Deucher wrote: > On Thu, Oct 31, 2019 at 8:15 PM Tuikov, Luben wrote: >> >> On 2019-10-31 3:29 a.m., Christian König wrote: >>> Am 31.10.19 um 00:43 schrieb Tuikov, Luben: Implement an accessor of adev->tmz.enabled. Let not code around access it as "if

Re: [PATCH] drm/amdgpu: implement TMZ accessor

2019-11-01 Thread Alex Deucher
On Thu, Oct 31, 2019 at 8:15 PM Tuikov, Luben wrote: > > On 2019-10-31 3:29 a.m., Christian König wrote: > > Am 31.10.19 um 00:43 schrieb Tuikov, Luben: > >> Implement an accessor of adev->tmz.enabled. Let not > >> code around access it as "if (adev->tmz.enabled)" > >> as the organization may

Re: [PATCH] drm/amdgpu: implement TMZ accessor

2019-10-31 Thread Tuikov, Luben
On 2019-10-31 3:29 a.m., Christian König wrote: > Am 31.10.19 um 00:43 schrieb Tuikov, Luben: >> Implement an accessor of adev->tmz.enabled. Let not >> code around access it as "if (adev->tmz.enabled)" >> as the organization may change. Instead... >> >> Recruit "bool amdgpu_is_tmz(adev)" to return

Re: [PATCH] drm/amdgpu: implement TMZ accessor

2019-10-31 Thread Christian König
Am 31.10.19 um 00:43 schrieb Tuikov, Luben: Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(adev)" to return exactly this Boolean value. That is, this function is now an

[PATCH] drm/amdgpu: implement TMZ accessor

2019-10-30 Thread Tuikov, Luben
Implement an accessor of adev->tmz.enabled. Let not code around access it as "if (adev->tmz.enabled)" as the organization may change. Instead... Recruit "bool amdgpu_is_tmz(adev)" to return exactly this Boolean value. That is, this function is now an accessor of an already initialized and set