On 08/29/2018 11:17 PM, Philip Yang wrote:
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
is zeroed already, memset it to zero again afterwards is unnecessary,
and in this case buggy because we only clear the first entry.
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a968
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Philip Yang
Sent: Wednesday, August 29, 2018 11:17:44 AM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Philip
Subject: [PATCH] drm/amdgpu: remove redundant memset
kvmalloc_array uses __GFP_ZERO flag ensures
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
is zeroed already, memset it to zero again afterwards is unnecessary,
and in this case buggy because we only clear the first entry.
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686
Signed-off-by: Philip Yang
---
drivers/gp
Am 29.08.2018 um 17:13 schrieb Philip Yang:
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
is zeroed already, memset it to zero again afterwards is unnecessary
and in this case buggy because we only clear the first entry.
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6
kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
is zeroed already, memset it to zero again afterwards is unnecessary
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(
Am 29.08.2018 um 17:01 schrieb Philip Yang:
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686
Signed-off-by: Philip Yang
You need to add a commit message, explaining why that can be removed.
With that done the patch is Reviewed-by: Christian König
.
Regards,
Christian.
---
drivers/g
Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 153c9be..33d9ce2 100644
--- a/driver
