Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-24 Thread Pierre-Loup A. Griffais
I can test some more tonight. I'll also try to prepare a standalone trace so you can observe the exact pattern being used on your end. Vulkan traces tend to be GPU and driver-specific. We'll use Mesa as the driver, but what GPU would be most convenient on your side for replaying? On our end I

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Christian König
Mhm, then I don't know what's going wrong here. Could be that the fence somehow ends up in a BO dependency. Pierre do you have some time for testing today? Or could you provide me some way to test this? Christian. Am 24.11.20 um 03:48 schrieb Pierre-Loup A. Griffais: I just built my

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Pierre-Loup A. Griffais
I just built my kernel with it and tested Horizon Zero Dawn on stock Proton 5.13, and it doesn't seem to change things there. This pattern looks identical as with before the kernel patch, as far as I can tell: https://imgur.com/a/1fZWgNG The last purple block is a piece of GPU work on the

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Marek Olšák
Pierre-Loup, does this do what you requested? Thanks, Marek On Mon, Nov 23, 2020 at 3:17 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > That the CPU round trip is gone now. > > Christian. > > Am 23.11.20 um 20:49 schrieb Marek Olšák: > > What is the behavior we should expect? >

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Christian König
That the CPU round trip is gone now. Christian. Am 23.11.20 um 20:49 schrieb Marek Olšák: What is the behavior we should expect? Marek On Mon, Nov 23, 2020 at 7:31 AM Christian König > wrote: Ping, Pierre/Marek does this change works as

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Marek Olšák
What is the behavior we should expect? Marek On Mon, Nov 23, 2020 at 7:31 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Ping, Pierre/Marek does this change works as expected? > > Regards, > Christian. > > Am 18.11.20 um 14:20 schrieb Christian König: > > This allows for

Re: [PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-23 Thread Christian König
Ping, Pierre/Marek does this change works as expected? Regards, Christian. Am 18.11.20 um 14:20 schrieb Christian König: This allows for optimizing the CPU round trip away. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-

[PATCH] drm/amdgpu: unpack dma_fence_chain containers during sync

2020-11-18 Thread Christian König
This allows for optimizing the CPU round trip away. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 27 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.h | 1 + 3 files changed, 29 insertions(+), 1