On 2018-06-28 08:31 PM, Alex Deucher wrote:
> On Thu, Jun 28, 2018 at 2:02 PM, Jiang, Sonny wrote:
>> Hi Alex,
>>
>>
>> What's your opinion about Michel's suggestion?
>
> You should definitely update amdgpu.rst to include the new
> documentation section. As for whether to have separate sections
gt; Thanks,
>
> Sonny
>
>
> From: Michel Dänzer
> Sent: Thursday, June 28, 2018 4:39:57 AM
> To: Jiang, Sonny
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: update documentation for amdgpu_drv.c
>
>
> Hi Sonny,
>
>
&g
Hi Alex,
What's your opinion about Michel's suggestion?
Thanks,
Sonny
From: Michel Dänzer
Sent: Thursday, June 28, 2018 4:39:57 AM
To: Jiang, Sonny
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: update documentation for amdgpu_drv.c
Hi
Hi Sonny,
would it be possible to put the documentation of each parameter directly
next to its definition / declaration? Otherwise, I'm afraid the
documentation will quickly fall out of date WRT the code.
> +/**
> + * DOC: module_parameters
Otherwise, this needs to be referenced in
On 06/28/2018 02:14 AM, Sonny Jiang wrote:
Signed-off-by: Sonny Jiang
Nick work for amdgpu parameters.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 117
1 file changed, 117 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
Signed-off-by: Sonny Jiang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 117
1 file changed, 117 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 6841497..8e418e4 100644
---
