RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-11 Thread Xu, Feifei
, October 10, 2023 6:14 PM To: Koenig, Christian ; Zhang, Hawking ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb If the behavior is correct, this patch looks like workaround HW reset not flushed the TLB or something can

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
To: Xu, Feifei ; Zhang, Hawking ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb Hi Feifei, yeah, that is correct behavior. The GMC callback should *not* get called during resume in a reset, because the reset needs to take

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb >> Then a TLB flush shouldn't be necessary on reset. A reset implies that the >> TLB is cleared as well. Hmm, in current implementation, when

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
Xu, Feifei ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb Am 09.10.23 um 03:50 schrieb Xu, Feifei: > [AMD Official Use Only - General] > > Hi, > >>> Based o

Recall: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
Xu, Feifei would like to recall the message, "[PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb".

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
lock not paried. Thanks, Feifei -Original Message- From: Christian König Sent: Monday, October 9, 2023 4:52 PM To: Xu, Feifei ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb Am 09.1

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Xu, Feifei
fei Sent: Tuesday, October 10, 2023 10:28 AM To: Zhang, Hawking ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb Yes, adev->gfx.is_poweron check will be applied in gmc_v11 callback, which will

Re: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-10 Thread Christian König
ecuted later. Thanks, Feifei -Original Message- From: Zhang, Hawking Sent: Monday, October 9, 2023 4:58 PM To: Xu, Feifei ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb [AMD Official Us

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-09 Thread Xu, Feifei
From: Zhang, Hawking Sent: Monday, October 9, 2023 4:58 PM To: Xu, Feifei ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb [AMD Official Use Only - General] adev->gfx.is_poweron check should alrea

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-09 Thread Zhang, Hawking
rds, Hawking -Original Message- From: Xu, Feifei Sent: Monday, October 9, 2023 09:51 To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb [AMD Official Use Only - General]

Re: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-09 Thread Christian König
Thanks, Feifei -Original Message- From: Wang, Yang(Kevin) Sent: Sunday, October 8, 2023 9:36 PM To: Xu, Feifei ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Xu, Feifei ; Koenig, Christian ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb -Or

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Xu, Feifei
Yang(Kevin) Sent: Sunday, October 8, 2023 9:36 PM To: Xu, Feifei ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Xu, Feifei ; Koenig, Christian ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb -Original Message- From: amd-gfx

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Wang, Yang(Kevin)
-Original Message- From: amd-gfx On Behalf Of Feifei Xu Sent: Sunday, October 8, 2023 6:07 PM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Xu, Feifei ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb To fix the gpu

[PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Feifei Xu
To fix the gpu recovery failed on GFX11 with gfxhub pagefault, flush gpu tlb after reset on GFX11. Gfxhub tlb flush need check if adev->gfx.is_poweron set. Fixes: d0c860f33553 ("drm/amdgpu: rework lock handling for flush_tlb v2") Signed-off-by: Feifei Xu ---