Am 2022-11-21 um 00:13 schrieb Ma Jun:
From: Felix Kuehling
Move the topology-locked part of kfd_topology_add_device into a separate
function to simlpify error handling and release the topology lock
consistently.
Reported-by: Dan Carpenter
Signed-off-by: Felix Kuehling
Signed-off-by: Ma Jun
From: Felix Kuehling
Move the topology-locked part of kfd_topology_add_device into a separate
function to simlpify error handling and release the topology lock
consistently.
Reported-by: Dan Carpenter
Signed-off-by: Felix Kuehling
Signed-off-by: Ma Jun
---
drivers/gpu/drm/amd/amdkfd/kfd_topo
Looks good. Feel free to send the revised patch to amd-gfx. I'll review it.
Thanks,
Felix
Am 2022-11-17 um 02:33 schrieb Ma, Jun:
Hi Felix,
I just tested your patch. It works fine on my test set with the following
little fix.
Regards,
Ma Jun
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_to
Hi Felix,
I just tested your patch. It works fine on my test set with the following
little fix.
Regards,
Ma Jun
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 7ea3ec1e9e75..7d6fbfbfeb79 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topolo
On Wed, Nov 16, 2022 at 03:49:18PM -0500, Felix Kuehling wrote:
> Am 2022-11-16 um 03:04 schrieb Ma Jun:
> > Release the topology_lock in error case
> >
> > Signed-off-by: Ma Jun
> > Reported-by: Dan Carpenter
> Dan, did you change your email address, is this one correct?
>
Yep.
I'm still aro
res = -ENODEV;
+ up_write(&topology_lock);
goto err;
}
From ceb79972cdd490de181a6895836e40bf4e93c631 Mon Sep 17 00:00:00 2001
From: Felix Kuehling
Date: Wed, 16 Nov 2022 15:38:44 -0500
Subject: [PATCH] drm/amdkf
Release the topology_lock in error case
Signed-off-by: Ma Jun
Reported-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index ef9c6fdfb88d
