Re: [PATCH] drm/amdkfd: move PTR_ERR under IS_ERR() condition

Hi Huoqing, Your patch is technically correct. However, I don't think it fixes any actual bug, and it changes a code path that has no performance implications. Therefore I would just leave it as it is. Regards,   Felix Am 2021-07-20 um 2:34 a.m. schrieb Cai Huoqing: > no need to get error code

[PATCH] drm/amdkfd: move PTR_ERR under IS_ERR() condition

no need to get error code when IS_ERR is false Signed-off-by: Cai Huoqing --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index