Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-31 Thread philip yang
On 2021-05-28 12:39 p.m., Eric Huang wrote: On 2021-05-28 11:23 a.m., Christian König wrote: Am 27.05.21 um 16:05 schrieb philip yang: On

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-28 Thread Eric Huang
On 2021-05-28 11:23 a.m., Christian König wrote: Am 27.05.21 um 16:05 schrieb philip yang: On 2021-05-26 5:25 p.m., Felix Kuehling wrote: Am 2021-05-26 um 3:21 p.m. schrieb Eric Huang: On 2021-05-25 3:16 p.m., Felix Kuehling wrote: Similar to a recent fix by Philip Yang 76e08b37d0aa

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-28 Thread Christian König
Am 27.05.21 um 16:05 schrieb philip yang: On 2021-05-26 5:25 p.m., Felix Kuehling wrote: Am 2021-05-26 um 3:21 p.m. schrieb Eric Huang: On 2021-05-25 3:16 p.m., Felix Kuehling wrote: Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush TLB if valid PDE turns into PTE"),

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-27 Thread philip yang
On 2021-05-26 5:25 p.m., Felix Kuehling wrote: Am 2021-05-26 um 3:21 p.m. schrieb Eric Huang: On 2021-05-25 3:16 p.m., Felix Kuehling wrote: Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush TLB if

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-26 Thread Felix Kuehling
Am 2021-05-26 um 3:21 p.m. schrieb Eric Huang: > > On 2021-05-25 3:16 p.m., Felix Kuehling wrote: >> Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush >> TLB if valid PDE turns into PTE"), there needs to be a conditional TLB >> flush after map, if any PDEs were unmapped and

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-26 Thread Eric Huang
On 2021-05-25 3:16 p.m., Felix Kuehling wrote: Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush TLB if valid PDE turns into PTE"), there needs to be a conditional TLB flush after map, if any PDEs were unmapped and turned into PTEs in the process. This is currently

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-25 Thread Felix Kuehling
Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush TLB if valid PDE turns into PTE"), there needs to be a conditional TLB flush after map, if any PDEs were unmapped and turned into PTEs in the process. This is currently returned by amdgpu_vm_bo_update_mapping in the

[PATCH] drm/amdkfd: move flushing TLBs from map to unmap

2021-05-25 Thread Eric Huang
It it to optimize memory allocation latency. Signed-off-by: Eric Huang diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 960913a35ee4..ab73741edb97 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++