RE: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-30 Thread Kim, Jonathan
ATCH] drm/amdkfd: report atomics support in io_links over > xgmi > > Am 2021-04-30 um 2:16 p.m. schrieb Zeng, Oak: > > Sorry I should be clearer. > > > > dev->gpu->pci_atomic_requested is set to the value of adev- > >have_atomics_support - see function > amdgp

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-30 Thread Felix Kuehling
Am 2021-04-30 um 2:16 p.m. schrieb Zeng, Oak: > Sorry I should be clearer. > > dev->gpu->pci_atomic_requested is set to the value of > adev->have_atomics_support - see function amdgpu_amdkfd_have_atomics_support. > adev->have_atomics_support is set through function > pci_enable_atomic_ops_to_ro

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-30 Thread Zeng, Oak
Sorry I should be clearer. dev->gpu->pci_atomic_requested is set to the value of adev->have_atomics_support - see function amdgpu_amdkfd_have_atomics_support. adev->have_atomics_support is set through function pci_enable_atomic_ops_to_root currently in amdgpu_device_init - I don't think this

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Felix Kuehling
Am 2021-04-29 um 9:12 p.m. schrieb Zeng, Oak: > I think part of this can be done more clean in amdgpu_device_init: > > r = 0; > If (!adev->gmc.xgmi.connected_to_cpu) > /* enable PCIE atomic ops */ > r = pci_enable_atomic_ops_to_root(adev->pdev, >

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Zeng, Oak
I think part of this can be done more clean in amdgpu_device_init: r = 0; If (!adev->gmc.xgmi.connected_to_cpu) /* enable PCIE atomic ops */ r = pci_enable_atomic_ops_to_root(adev->pdev, PCI_EXP_DEVCAP2_ATOMI

RE: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Kim, Jonathan
: Thursday, April 29, 2021 10:49 AM > >> To: Kim, Jonathan ; amd- > >> g...@lists.freedesktop.org > >> Cc: Zeng, Oak ; Errabolu, Ramesh > >> > >> Subject: Re: [PATCH] drm/amdkfd: report atomics support in io_links > >> over xgmi > >> > >>

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Felix Kuehling
ktop.org >> Cc: Zeng, Oak ; Errabolu, Ramesh >> >> Subject: Re: [PATCH] drm/amdkfd: report atomics support in io_links over >> xgmi >> >> Am 2021-04-29 um 5:36 a.m. schrieb Jonathan Kim: >>> Link atomics support over xGMI should be reported independently of PC

RE: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Kim, Jonathan
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Kuehling, Felix > Sent: Thursday, April 29, 2021 10:49 AM > To: Kim, Jonathan ; amd- > g...@lists.freedesktop.org > Cc: Zeng, Oak ; Errabolu, Ramesh > > Subject: Re: [PATCH] dr

Re: [PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Felix Kuehling
Am 2021-04-29 um 5:36 a.m. schrieb Jonathan Kim: > Link atomics support over xGMI should be reported independently of PCIe. I don't understand this change. I don't see any code that gets executed if (adev->gmc.xgmi.connected_to_cpu). Where is the code that reports atomics support for this case? A

[PATCH] drm/amdkfd: report atomics support in io_links over xgmi

2021-04-29 Thread Jonathan Kim
Link atomics support over xGMI should be reported independently of PCIe. Signed-off-by: Jonathan Kim Tested-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 29 ++- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/