rom: Grodzovsky, Andrey
Sent: Thursday, August 26, 2021 11:05 AM
To: Liu, Monk ; Christian König ;
amd-gfx@lists.freedesktop.org; dri-devel
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
On 2021-08-25 10:31 p.m., Liu, Monk wrote:
[AMD Official Use Only]
Hi Andrey
Monk Liu | Cloud-GPU Core team
--
-Original Message-
From: Grodzovsky, Andrey
Sent: Thursday, August 26, 2021 11:05 AM
To: Liu, Monk ; Christian König
; amd-gfx@lists.freedesktop.org; dri-devel
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
On 2021-08
2021 2:20 AM
To: Christian König ; Liu, Monk ;
amd-gfx@lists.freedesktop.org; dri-devel
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
On 2021-08-25 8:11 a.m., Christian König wrote:
No, this would break that logic here.
See drm_sched_start_timeout() can be called m
stian König ; Liu, Monk
; amd-gfx@lists.freedesktop.org; dri-devel
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
On 2021-08-25 8:11 a.m., Christian König wrote:
> No, this would break that logic here.
>
> See drm_sched_start_timeout() can be called multiple times
ssage-
From: Christian König
Sent: Wednesday, August 25, 2021 8:11 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
No, this would break that logic here.
See drm_sched_start_timeout() can be called multiple times, this is in
Cloud-GPU Core team
--
-Original Message-
From: Christian König
Sent: Wednesday, August 25, 2021 2:32 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
Well NAK to that approach. First of all your bug analyses is incorrect.
Please cc dri-devel on all scheduler patches. It's core functionality.
Alex
On Wed, Aug 25, 2021 at 12:14 AM Monk Liu wrote:
>
> the original logic is wrong that the timeout will not be retriggerd
> after the previous job siganled, and that lead to the scenario that all
> jobs in the same
Core team
--
-Original Message-
From: Liu, Monk
Sent: Wednesday, August 25, 2021 7:55 PM
To: 'Christian König' ;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)
[AMD Official Use Only]
The timeout started by queue_de
y
Thanks
--
Monk Liu | Cloud-GPU Core team
--
-Original Message-
From: Liu, Monk
Sent: Wednesday, August 25, 2021 7:55 PM
To: 'Christian König' ;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)
[AM
-Original Message-
From: Christian König
Sent: Wednesday, August 25, 2021 2:32 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)
Well NAK to that approach. First of all your bug analyses is incorrect
Well NAK to that approach. First of all your bug analyses is incorrect.
The timeout started by queue_delayed_work() in drm_sched_start_timeout()
is paired with the cancel_delayed_work() in drm_sched_get_cleanup_job().
So you must have something else going on here.
Then please don't use
the original logic is wrong that the timeout will not be retriggerd
after the previous job siganled, and that lead to the scenario that all
jobs in the same scheduler shares the same timeout timer from the very
begining job in this scheduler which is wrong.
we should modify the timer everytime a
12 matches
Mail list logo
