Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-20 Thread Rodrigo Siqueira
On 04/19, Christian König wrote: > Am 17.04.20 um 23:43 schrieb Rodrigo Siqueira: > > Hi, > > > > Wyatt made the below patch for fixing this issue. I can apply it on top > > of this patchset if you all agree. > > > > [Why] > > Current code does not guarantee the correct endianness of memory

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-19 Thread Christian König
Am 17.04.20 um 23:43 schrieb Rodrigo Siqueira: Hi, Wyatt made the below patch for fixing this issue. I can apply it on top of this patchset if you all agree. [Why] Current code does not guarantee the correct endianness of memory being copied to fw, specifically in the case where cpu isn't

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-19 Thread Christian König
Am 17.04.20 um 17:40 schrieb Harry Wentland: On 2020-04-17 8:09 a.m., Christian König wrote: Am 17.04.20 um 12:43 schrieb Michel Dänzer: On 2020-04-17 11:22 a.m., Christian König wrote: Agreed, just wanted to reply as well since I think something is not correctly understood here. The

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-17 Thread Rodrigo Siqueira
Hi, Wyatt made the below patch for fixing this issue. I can apply it on top of this patchset if you all agree. [Why] Current code does not guarantee the correct endianness of memory being copied to fw, specifically in the case where cpu isn't little endian. [How] Windows and Diags are always

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-17 Thread Harry Wentland
On 2020-04-17 8:09 a.m., Christian König wrote: > Am 17.04.20 um 12:43 schrieb Michel Dänzer: >> On 2020-04-17 11:22 a.m., Christian König wrote: >>> Agreed, just wanted to reply as well since I think something is not >>> correctly understood here. >>> >>> The cpu_to_be16() and be16_to_cpu()

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-17 Thread Christian König
Am 17.04.20 um 12:43 schrieb Michel Dänzer: On 2020-04-17 11:22 a.m., Christian König wrote: Agreed, just wanted to reply as well since I think something is not correctly understood here. The cpu_to_be16() and be16_to_cpu() functions work different depending on which architecture/endianess

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-17 Thread Michel Dänzer
On 2020-04-17 11:22 a.m., Christian König wrote: > Agreed, just wanted to reply as well since I think something is not > correctly understood here. > > The cpu_to_be16() and be16_to_cpu() functions work different depending > on which architecture/endianess your are. > > So they should be a NO-OP

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-17 Thread Christian König
Siqueira *Sent:* Thursday, April 16, 2020 7:40 PM *To:* amd-gfx@lists.freedesktop.org *Cc:* Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Wood, Wyatt ; Lakha, Bhawanpreet ; Koo, Anthony *Subject:* [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table From

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-16 Thread Deucher, Alexander
: Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Wood, Wyatt ; Lakha, Bhawanpreet ; Koo, Anthony Subject: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table From: Wyatt Wood [Why] Since x86 and dmcub are both little endian, byte swapping isn't necessary

[PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

2020-04-16 Thread Rodrigo Siqueira
From: Wyatt Wood [Why] Since x86 and dmcub are both little endian, byte swapping isn't necessary. Dmcu requires byte swapping as it is big endian. [How] Add flag to function definitions to determine if byte swapping is necessary. Signed-off-by: Wyatt Wood Reviewed-by: Anthony Koo Acked-by: