Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Nirmoy
*From:* amd-gfx on behalf of Nirmoy Das *Sent:* Saturday, March 13, 2021 1:08 AM *To:* Koenig, Christian *Cc:* Das, Nirmoy ; amd-gfx@lists.freedesktop.org *Subject:* [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock KIQ ring is being operated by kfd as well as amdgpu. KFD is using

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Wang, Kevin(Yang)
in one thread.. thanks. Best Regards, Kevin From: amd-gfx on behalf of Nirmoy Das Sent: Saturday, March 13, 2021 1:08 AM To: Koenig, Christian Cc: Das, Nirmoy ; amd-gfx@lists.freedesktop.org Subject: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Christian König
Am 12.03.21 um 18:08 schrieb Nirmoy Das: KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Signed-off-by: Nirmoy Das Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 15 +++ 1 file

[PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-12 Thread Nirmoy Das
KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-12 Thread Christian König
Am 12.03.21 um 11:24 schrieb Nirmoy: On 3/12/21 10:52 AM, Christian König wrote: Am 12.03.21 um 10:49 schrieb Nirmoy Das: KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Ah, now I knew which functions you mean. This

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-12 Thread Nirmoy
On 3/12/21 10:52 AM, Christian König wrote: Am 12.03.21 um 10:49 schrieb Nirmoy Das: KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Ah, now I knew which functions you mean. This is not strictly necessary because that

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-12 Thread Christian König
Am 12.03.21 um 10:49 schrieb Nirmoy Das: KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Ah, now I knew which functions you mean. This is not strictly necessary because that stuff is only called during bootup and not

[PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-12 Thread Nirmoy Das
KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git