Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Bhardwaj, Rajneesh
Hi Felix While the detailed review for this is already going on, you might want to consider below hunk if you happen to send v2. --- a/drivers/gpu/drm/amd/amdkfd/kfd_ipc.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_ipc.c @@ -100,11 +100,10 @@ void kfd_ipc_obj_put(struct kfd_ipc_obj **obj)     }

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 01:36:41PM +0200, Christian König wrote: > Am 14.07.20 um 11:53 schrieb Daniel Vetter: > > On Tue, Jul 14, 2020 at 11:28:12AM +0200, Christian König wrote: > > > Am 14.07.20 um 10:58 schrieb Daniel Vetter: > > > > On Tue, Jul 14, 2020 at 02:26:36PM +1000, Dave Airlie wrote:

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Christian König
Am 14.07.20 um 11:53 schrieb Daniel Vetter: On Tue, Jul 14, 2020 at 11:28:12AM +0200, Christian König wrote: Am 14.07.20 um 10:58 schrieb Daniel Vetter: On Tue, Jul 14, 2020 at 02:26:36PM +1000, Dave Airlie wrote: On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: Am 2020-07-13 um 11:28

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 11:28:12AM +0200, Christian König wrote: > Am 14.07.20 um 10:58 schrieb Daniel Vetter: > > On Tue, Jul 14, 2020 at 02:26:36PM +1000, Dave Airlie wrote: > > > On Tue, 14 Jul 2020 at 14:09, Felix Kuehling > > > wrote: > > > > Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie:

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Christian König
Am 14.07.20 um 10:58 schrieb Daniel Vetter: On Tue, Jul 14, 2020 at 02:26:36PM +1000, Dave Airlie wrote: On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: This allows exporting and

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 02:26:36PM +1000, Dave Airlie wrote: > On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: > > > > Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > > > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling > > > wrote: > > >> This allows exporting and importing buffers. The API

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-14 Thread Felix Kuehling
riginal Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Tuesday, July 14, 2020 11:15 AM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Deucher, Alexander ; daniel.vet...@ffwll.ch; > airl...@gmail.com > Subject: [PATCH 1/1] d

RE: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Li, Dennis
, 2020 11:15 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Deucher, Alexander ; daniel.vet...@ffwll.ch; airl...@gmail.com Subject: [PATCH 1/1] drm/amdkfd: Add IPC API This allows exporting and importing buffers. The API generates handles that can be used with the HIP IPC

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: > > Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > >> This allows exporting and importing buffers. The API generates handles > >> that can be used with the HIP IPC API, i.e. big

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Felix Kuehling
Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: >> This allows exporting and importing buffers. The API generates handles >> that can be used with the HIP IPC API, i.e. big numbers rather than >> file descriptors. > First up why? I get the

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > > This allows exporting and importing buffers. The API generates handles > that can be used with the HIP IPC API, i.e. big numbers rather than > file descriptors. First up why? I get the how. > + * @share_handle is a 128 bit random number

[PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Felix Kuehling
This allows exporting and importing buffers. The API generates handles that can be used with the HIP IPC API, i.e. big numbers rather than file descriptors. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 5 + .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |