Re: [PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-24 Thread Christian König
Looks like a step into the right direction to me. With Felix comment addressed patch #1 and #2 are Acked-by: Christian König . For patch #3 I agree with Alex that we need more kerneldoc, when that is done we can probably add rb to that as well. Regards, Christian. Am 24.08.2018 um 00:21

Re: [PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-23 Thread Felix Kuehling
I believe you also need to edit drivers/gpu/drm/Kconfig. Otherwise amdkfd/Kconfig will be included twice. With that fixed, this commit is Reviewed-by: Felix Kuehling But let's give amdgpu reviewers some more time to respond. Thanks,   Felix On 2018-08-23 11:17 AM, Amber Lin wrote: > Since KFD

[PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-23 Thread Amber Lin
Since KFD is only supported by single GPU driver, it makes sense to merge amdgpu and amdkfd into one module. This patch is the initial step: merge Kconfig and Makefile. Change-Id: I21c996ba29d393c1bf8064bdb2f5d89541159649 Signed-off-by: Amber Lin --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1