Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-20 Thread Deucher, Alexander
state change Hi Alex, Comment inline. > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, June 19, 2018 11:17 PM > To: Quan, Evan > Cc: amd-gfx list > Subject: Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on &g

RE: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-20 Thread Quan, Evan
10/13] drm/amd/powerplay: apply clocks adjust rules on power state change Hi Evan, did we need to check the following flags on vega12?will driver set those flags when user select the umd_pstate? PHM_PlatformCaps_UMDPState/PHM_PlatformCaps_PState. Best Regards Rex 获取 Outlook for Android<ht

RE: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-20 Thread Quan, Evan
Hi Alex, Comment inline. > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, June 19, 2018 11:17 PM > To: Quan, Evan > Cc: amd-gfx list > Subject: Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on > power sta

Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-19 Thread Zhu, Rex
md-gfx on behalf of Alex Deucher Sent: Tuesday, June 19, 2018 11:16:44 PM To: Quan, Evan Cc: amd-gfx list Subject: Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change On Tue, Jun 19, 2018 at 3:39 AM, Evan Quan wrote: > The clocks hard/soft min/max clo

Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-19 Thread Alex Deucher
On Tue, Jun 19, 2018 at 3:39 AM, Evan Quan wrote: > The clocks hard/soft min/max clock levels will be adjusted > correspondingly. Also note that this add the apply_clocks_adjust_rules callback which is used to validate the clock settings on a power state change. One other comment below. > >

[PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-19 Thread Evan Quan
The clocks hard/soft min/max clock levels will be adjusted correspondingly. Change-Id: I2c4b6cd6756d40a28933f0c26b9e1a3d5078bab8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 162 + drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.h | 2