Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-13 Thread Michel Dänzer
On 6/12/23 20:14, Pillai, Aurabindo wrote: > > I want to double check if we're identifying the correct monitor for applying > the workaround. Could you please try the attached patch and let me know the > panel id ? amdgpu: ### Not applying any edid quirk for panel 4c2d71ac I'm attaching the

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-12 Thread Pillai, Aurabindo
Subject: Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit On 6/8/23 16:31, Pillai, Aurabindo wrote: > > Thanks Michel, > > I reached out to windows driver team, and they have a monitor specific quirk > to disable FAMS on this model. I suspect the issue is only present o

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Michel Dänzer
On 6/8/23 16:31, Pillai, Aurabindo wrote: > > Thanks Michel, > > I reached out to windows driver team, and they have a monitor specific quirk > to disable FAMS on this model. I suspect the issue is only present on certain > fw revisions on the monitor which is why we cant see your issue. > >

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Pillai, Aurabindo
, Wesley Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Li, Roman ; amd-gfx@lists.freedesktop.org ; Chiu, Solomon ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin ; Kotarac, Pavle Subject: Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Michel Dänzer
On 6/7/23 19:35, Pillai, Aurabindo wrote: > > Do you see the issue if you force disable FAMS? Neither hang occurs with FAMS disabled. -- Earthling Michel Dänzer| https://redhat.com Libre software enthusiast | Mesa and Xwayland developer

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-07 Thread Pillai, Aurabindo
: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit On 6/6/23 20:01, Pillai, Aurabindo wrote: > > I'm attaching another DMCUB firmware which has the bug fix for the hang we > saw at our end and some added tracing enabled. Still runs into the newer hang when starting a KDE Plasm

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-07 Thread Michel Dänzer
On 6/6/23 20:01, Pillai, Aurabindo wrote: > > I'm attaching another DMCUB firmware which has the bug fix for the hang we > saw at our end and some added tracing enabled. Still runs into the newer hang when starting a KDE Plasma Wayland session. Should I try this for starting the game without

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-06 Thread Michel Dänzer
On 6/2/23 19:13, Pillai, Aurabindo wrote: > > AMD driver package also contains various firmware that could make a > difference. I tried the firmware from amdgpu-dkms-firmware_1%3a5.18.13.50405-1577590.20.04_all.deb, it didn't help for either hang. I also tried the firmware from current

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-02 Thread Pillai, Aurabindo
-gfx@lists.freedesktop.org ; Chalmers, Wesley Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin ; Kotarac, Pavle Subject: Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-01 Thread Michel Dänzer
On 6/1/23 17:45, Pillai, Aurabindo wrote: > > I see, thanks for the info. I'll try repro'ing it locally. Thanks. Note that I'm using a GNOME Wayland session, which doesn't support VRR upstream yet (I'm building mutter with https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1154 for that).

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-01 Thread Pillai, Aurabindo
-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit On 5/31/23 22:14, Aurabindo Pillai wrote: > O

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-01 Thread Michel Dänzer
On 5/31/23 22:14, Aurabindo Pillai wrote: > On 5/11/23 03:06, Michel Dänzer wrote: >> On 5/10/23 22:54, Aurabindo Pillai wrote: >>> On 5/10/23 09:20, Michel Dänzer wrote: On 5/9/23 23:07, Pillai, Aurabindo wrote: > > Sorry - the firmware in the previous message is for DCN32. For

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-05-11 Thread Michel Dänzer
On 5/10/23 22:54, Aurabindo Pillai wrote: > On 5/10/23 09:20, Michel Dänzer wrote: >> On 5/9/23 23:07, Pillai, Aurabindo wrote: >>> >>> Sorry - the firmware in the previous message is for DCN32. For Navi2x, >>> please use the firmware attached here. >> >> Same problem (contents of

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-05-10 Thread Aurabindo Pillai
>> ; amd-gfx@lists.freedesktop.org >> ; Chalmers, Wesley >> *Cc:* Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) >> ; Wentland, Harry ; Siqueira, >> Rodrigo ; Li, Roman ; Chiu, >> Solomon ; Lin, Wayne ; Lakha, >> Bhawanpreet ; Gutierrez, Agustin >> ; Kot

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-05-10 Thread Michel Dänzer
Chao-kai (Stylon) ; Li, Sun peng (Leo) > ; Wentland, Harry ; Siqueira, > Rodrigo ; Li, Roman ; Chiu, > Solomon ; Lin, Wayne ; Lakha, > Bhawanpreet ; Gutierrez, Agustin > ; Kotarac, Pavle > *Subject:* Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe comm

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-05-09 Thread Michel Dänzer
On 4/14/23 17:52, Qingqing Zhuo wrote: > From: Wesley Chalmers > > [WHY] > Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a > pipe commit can cause underflow. > > [HOW] > Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets > optimized_required. > > This

[PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-04-14 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required. This change expects that Freesync requests are blocked when