RE: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-17 Thread Liang, Prike
ret = -EAGAIN; } return ret; } Thanks Prike From: Christian König Sent: Wednesday, May 15, 2019 3:05 PM To: Liang, Prike ; Marek Olšák Cc: Zhou, David(ChunMing) ; dri-devel ; amd-gfx mailing list Subject: Re: [PATCH 11/11] drm/amdgpu: stop

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Zhou, David(ChunMing)
Ah, sorry, I missed "+ ttm_bo_move_to_lru_tail(bo, NULL);". Right, moving them to end before releasing is fixing my concern. Sorry for noise. -David Original Message Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU duri

Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Koenig, Christian
ssage Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"Olsak, Marek" ,"Liang, Prike" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org&l

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Zhou, David(ChunMing)
Isn't this patch trying to stop removing for all BOs from bo list? -David Original Message Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"

Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Christian König
passed from user space? you can verify it by some games, performance could be different much between multiple runnings. -David Original Message Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Zhou, David(ChunMing

Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Christian König
\n", bo); +   goto error; +    }     }     bo->pin_count = 1; Thanks, Prike *From:* Marek Olšák *Sent:* Wednesday, May 15, 2019 3:33 AM *To:* Christian König *Cc:* Zhou, David(ChunMing) ; Liang, Prike ; dri-devel ; amd-gfx mailing list *Subject:* Re: [PATCH 11/11]

RE: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Liang, Prike
15, 2019 3:33 AM To: Christian König Cc: Zhou, David(ChunMing) ; Liang, Prike ; dri-devel ; amd-gfx mailing list Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS [CAUTION: External Email] This series fixes the OOM errors. However, if I torture the kernel driver more,

Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Marek Olšák
This series fixes the OOM errors. However, if I torture the kernel driver more, I can get it to deadlock and end up with unkillable processes. I can also get an OOM error. I just ran the test 5 times: AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears & AMD_

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Zhou, David(ChunMing)
(ChunMing): my only concern is how to fresh LRU when bo is from bo list. -David Original Message -------- Subject: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Olsak, Marek" ,"Zhou, David(ChunMing)" ,"

Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Christian König
Hui? What do you mean with that? Christian. Am 14.05.19 um 15:12 schrieb Zhou, David(ChunMing): my only concern is how to fresh LRU when bo is from bo list. -David Original Message Subject: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Zhou, David(ChunMing)
my only concern is how to fresh LRU when bo is from bo list. -David Original Message Subject: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Olsak, Marek" ,"Zhou, David(ChunMing)" ,"Liang, Prike" ,d

[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Christian König
This avoids OOM situations when we have lots of threads submitting at the same time. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/