Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

On 27/04/17 04:39 PM, Michel Dänzer wrote: > On 27/04/17 04:19 AM, Alex Xie wrote: >> Hi, >> >> I knew this is part of ioctl. And I intended to fix this interruptible >> waiting in an ioctl. > > It's by design, nothing that needs fixing in the case of an ioctl. > > >> 1. The wait is short.

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

On 27/04/17 06:05 PM, Christian König wrote: > >> 2. In this function and caller functions, the error handling for such >> interrupt is complicated and risky. When the waiting is interrupted by >> a signal, the callers of this function need to handle this interrupt >> error. I traced the calling

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

1. The wait is short. There is not much benefit by interruptible waiting. The BO is a frame buffer BO. Are there many competitors to lock this BO? If not, the wait is very short. This is my main reason to change. The problem is that all those waits can block the MM subsystem from reclaiming

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

On 27/04/17 04:19 AM, Alex Xie wrote: > Hi, > > I knew this is part of ioctl. And I intended to fix this interruptible > waiting in an ioctl. It's by design, nothing that needs fixing in the case of an ioctl. > 1. The wait is short. There is not much benefit by interruptible > waiting. The BO

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

Hi, I knew this is part of ioctl. And I intended to fix this interruptible waiting in an ioctl. ioctl is one of driver interfaces, where interruptible waiting is good in some scenarios. For example, if ioctl performs IO operations in atomic way, we don't want ioctl to be interrupted by a

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

Am 26.04.2017 um 03:17 schrieb Michel Dänzer: On 26/04/17 06:25 AM, Alex Xie wrote: 1. The wait is short. There is not much benefit by interruptible waiting. 2. In this function and caller functions, the error handling for such interrupt is complicated and risky. Change-Id:

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

On 26/04/17 06:25 AM, Alex Xie wrote: > 1. The wait is short. There is not much benefit by > interruptible waiting. > 2. In this function and caller functions, the error > handling for such interrupt is complicated and risky. > > Change-Id: I289674ecd3f5ef20c93fe63e33df6d668b3c2edc >

[PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

1. The wait is short. There is not much benefit by interruptible waiting. 2. In this function and caller functions, the error handling for such interrupt is complicated and risky. Change-Id: I289674ecd3f5ef20c93fe63e33df6d668b3c2edc Signed-off-by: Alex Xie ---

Re: [PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting 1. The signal interrupt can affect the expected behaviour. 2. There is no good mechanism to handle the corresponding error. When signal int

You somehow messed up the commit message. Everything got mangled into the subject line while sending the mails. Apart from that the change looks good to me and with the commit message fixed is Reviewed-by: Christian König Regards, Christian. Am 24.04.2017 um 21:34

[PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting 1. The signal interrupt can affect the expected behaviour. 2. There is no good mechanism to handle the corresponding error. When signal interru

Change-Id: I6889a4d9dd2703bcf5d448d18f6af51c496a93c9 Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c