Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Edward O'Callaghan
.freedesktop.org > *Subject:* Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in > 'cik_ih_ring_entry' directly > > NAK, don't use bitfields to decode hardware values. They aren't portable. > > Regards, > Christian. > > Am 27.09.2016 um 14:47 schrieb

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread StDenis, Tom
rg Subject: Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly NAK, don't use bitfields to decode hardware values. They aren't portable. Regards, Christian. Am 27.09.2016 um 14:47 schrieb Edward O'Callaghan: > Signed-off-by: Edward O&#x

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Oded Gabbay
Christian is correct. That is not portable to other architectures Oded On Tue, Sep 27, 2016 at 3:52 PM, Christian König wrote: > NAK, don't use bitfields to decode hardware values. They aren't portable. > > Regards, > Christian. > > > Am 27.09.2016 um 14:47 schrieb Edward O'Callaghan: >> >> Sign

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Christian König
NAK, don't use bitfields to decode hardware values. They aren't portable. Regards, Christian. Am 27.09.2016 um 14:47 schrieb Edward O'Callaghan: Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +-- drivers/gpu/drm/amd/amdkfd/cik_int.h

[PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +-- drivers/gpu/drm/amd/amdkfd/cik_int.h | 20 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.