Re: [PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path

2019-09-23 Thread Zhao, Yong
Okay, I will incorporate Shaoyun's input. Yong From: Liu, Shaoyun Sent: Monday, September 23, 2019 10:27 AM To: Zhao, Yong ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path Probably rename

Re: [PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path

2019-09-23 Thread Liu, Shaoyun
Probably rename to sdma_rlc to avoid the  confusion of  rlc used in other amdgpu driver . Regards shaoyun.liu On 2019-09-22 11:56 p.m., Zhao, Yong wrote: > The old name is prone to confusion. The register offset is for a RLC queue > rather than a SDMA engine. The value is not a base address,

Re: [PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path

2019-09-23 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zhao, Yong Sent: Sunday, September 22, 2019 11:56 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path The old name

[PATCH 2/2] drm/amdkfd: Use better name for sdma queue non HWS path

2019-09-22 Thread Zhao, Yong
The old name is prone to confusion. The register offset is for a RLC queue rather than a SDMA engine. The value is not a base address, but a register offset. Change-Id: I55fb835f2105392344b1c17323bb55c03f927836 Signed-off-by: Yong Zhao --- .../drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 85