Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-27 Thread Felix Kuehling
On 2023-09-26 12:39, Alex Deucher wrote: I think this was an abstraction back from when kfd supported both radeon and amdgpu. Since we just support amdgpu now, there is no more need for this and we can use the amdgpu structures directly. This also avoids having the kfd_cu_info structures on

Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-27 Thread Felix Kuehling
On 2023-09-26 15:29, Arnd Bergmann wrote: On Tue, Sep 26, 2023, at 20:47, Deucher, Alexander wrote: From: Arnd Bergmann Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote: I think this was an abstraction back from when kfd

Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-26 Thread Arnd Bergmann
On Tue, Sep 26, 2023, at 20:47, Deucher, Alexander wrote: >> From: Arnd Bergmann >> Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info >> >> On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote: >> > I think this was an abstraction back from when kfd supp

RE: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-26 Thread Deucher, Alexander
[Public] > -Original Message- > From: Arnd Bergmann > Sent: Tuesday, September 26, 2023 1:49 PM > To: Deucher, Alexander ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info > > On Tue, Sep 26, 2023, at 18:39, Alex De

Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-26 Thread Arnd Bergmann
On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote: > I think this was an abstraction back from when > kfd supported both radeon and amdgpu. Since we just > support amdgpu now, there is no more need for this and > we can use the amdgpu structures directly. > > This also avoids having the

[PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

2023-09-26 Thread Alex Deucher
I think this was an abstraction back from when kfd supported both radeon and amdgpu. Since we just support amdgpu now, there is no more need for this and we can use the amdgpu structures directly. This also avoids having the kfd_cu_info structures on the stack when inlining which can blow up the