Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Zhao, Yong
>> Yong >> >> From: Kuehling, Felix >> Sent: Wednesday, February 6, 2019 11:26 AM >> To: Zhao, Yong; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr() >>

Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Christian König
o, Yong; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr() Are you sure about this? Typically 64-bit doorbells don't wrap around. But this one does. If the IH doorbell wraps around, there is no reason why it needs to be 64-bit, so I suspect it may still be a

Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Alex Deucher
he *2 and << 1 conversions from 64-bit index to dword > index are all removed. > > Regards, > Yong > > From: Kuehling, Felix > Sent: Wednesday, February 6, 2019 11:26 AM > To: Zhao, Yong; amd-gfx@lists.freedesktop.org > Su

Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Zhao, Yong
ktop.org Subject: Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr() Are you sure about this? Typically 64-bit doorbells don't wrap around. But this one does. If the IH doorbell wraps around, there is no reason why it needs to be 64-bit, so I suspect it may still be a 32-bit doorbell.

Re: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Kuehling, Felix
, Yong Sent: Wednesday, February 6, 2019 10:49 AM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr() Clearly, it should be a 64-bit doorbell operation. Change-Id: I644a2ebcb18c2ede24ee15692a6189efad10a35c Signed-off-by: Yong Zhao

[PATCH 2/3] drm/amdgpu: Fix a typo in vega10_ih_set_rptr()

2019-02-06 Thread Zhao, Yong
Clearly, it should be a 64-bit doorbell operation. Change-Id: I644a2ebcb18c2ede24ee15692a6189efad10a35c Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c