Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 12:45 PM zhoucm1 wrote: > > > [snip] > >>> Went boom: > >>> > >>> https://bugs.freedesktop.org/show_bug.cgi?id=108490 > >>> > >>> Can we revert pls? > >> Sorry for bug, please. > > In fact, the bug is already caught and fixed, just the fix part isn't > > in patch#1, but in

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
[snip] Went boom: https://bugs.freedesktop.org/show_bug.cgi?id=108490 Can we revert pls? Sorry for bug, please. In fact, the bug is already caught and fixed, just the fix part isn't in patch#1, but in patch#2: Have you reverted? If not, I can send that fix in one minute. Regards, David

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 17:20, zhoucm1 wrote: On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: > > > On 2018年10月18日 19:50, Christian König wrote: > > Am 18.10.18 um 05:11 schrieb zhoucm1: > > > > > > > > > On 2018年10月17日 18:24, Daniel Vetter wrote: > > > > On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian > > > > wrote: > > > >

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Chris Wilson
Quoting Chunming Zhou (2018-10-15 09:55:48) > This patch is for VK_KHR_timeline_semaphore extension, semaphore is called > syncobj in kernel side: > This extension introduces a new type of syncobj that has an integer payload > identifying a point in a timeline. Such timeline syncobjs support the

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-18 Thread zhoucm1
On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am 17.10.18 um 11:17 schrieb zhoucm1: [SNIP]    +struct drm_syncobj_signal_pt { +    struct

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-18 Thread Christian König
Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am 17.10.18 um 11:17 schrieb zhoucm1: [SNIP]    +struct drm_syncobj_signal_pt { +    struct dma_fence_array *base; Out of curiosity, why the pointer

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread zhoucm1
On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am 17.10.18 um 11:17 schrieb zhoucm1: [SNIP] +struct drm_syncobj_signal_pt { +struct dma_fence_array *base; Out of curiosity, why the pointer and not embedding? base is kinda

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread zhoucm1
+Jason as well. On 2018年10月17日 18:22, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:17 AM zhoucm1 wrote: On 2018年10月17日 16:09, Daniel Vetter wrote: On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote: This patch is for VK_KHR_timeline_semaphore extension, semaphore is called

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: > > Am 17.10.18 um 11:17 schrieb zhoucm1: > > [SNIP] > >>> +struct drm_syncobj_signal_pt { > >>> +struct dma_fence_array *base; > >> Out of curiosity, why the pointer and not embedding? base is kinda > >> misleading for a pointer. >

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 11:17 AM zhoucm1 wrote: > > > > On 2018年10月17日 16:09, Daniel Vetter wrote: > > On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote: > >> This patch is for VK_KHR_timeline_semaphore extension, semaphore is called > >> syncobj in kernel side: > >> This extension

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread Koenig, Christian
Am 17.10.18 um 11:17 schrieb zhoucm1: > [SNIP] >>>   +struct drm_syncobj_signal_pt { >>> +    struct dma_fence_array *base; >> Out of curiosity, why the pointer and not embedding? base is kinda >> misleading for a pointer. > Yeah, Christian doesn't like signal_pt lifecycle same as fence, so >

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread zhoucm1
On 2018年10月17日 16:09, Daniel Vetter wrote: On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote: This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-17 Thread Daniel Vetter
On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote: > This patch is for VK_KHR_timeline_semaphore extension, semaphore is called > syncobj in kernel side: > This extension introduces a new type of syncobj that has an integer payload > identifying a point in a timeline. Such timeline

[PATCH 2/7] drm: add syncobj timeline support v8

2018-10-15 Thread Chunming Zhou
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying a point in a timeline. Such timeline syncobjs support the following operations: * CPU query - A host