Re: [PATCH 3/3] drm/amdgpu/navi10: add OD support for restoring default table

2020-01-28 Thread Alex Deucher
On Tue, Jan 28, 2020 at 1:49 PM Matt Coffin wrote: > > > > On 1/28/20 10:26 AM, Alex Deucher wrote: > > On Tue, Jan 28, 2020 at 11:44 AM Matt Coffin wrote: > > > I just copied that vega20 did. You may be right. I haven't paged the > > recent SMU interface stuff into my head in a while. If so,

Re: [PATCH 3/3] drm/amdgpu/navi10: add OD support for restoring default table

2020-01-28 Thread Matt Coffin
On 1/28/20 10:26 AM, Alex Deucher wrote: > On Tue, Jan 28, 2020 at 11:44 AM Matt Coffin wrote: > I just copied that vega20 did. You may be right. I haven't paged the > recent SMU interface stuff into my head in a while. If so, we should > also fix the vega20_ppt.c code. The vega20_ppt code

Re: [PATCH 3/3] drm/amdgpu/navi10: add OD support for restoring default table

2020-01-28 Thread Alex Deucher
On Tue, Jan 28, 2020 at 11:44 AM Matt Coffin wrote: > > For this, I believe we're updating `table_context->overdrive_table` with > the values set by the user, wouldn't the intended behavior here be to > restore the settings that were there on boot? > Correct. > > > If so, I think we'd have to ca

Re: [PATCH 3/3] drm/amdgpu/navi10: add OD support for restoring default table

2020-01-28 Thread Matt Coffin
For this, I believe we're updating `table_context->overdrive_table` with the values set by the user, wouldn't the intended behavior here be to restore the settings that were there on boot? If so, I think we'd have to cache the overdrive table that was there on boot, and use that in the response

[PATCH 3/3] drm/amdgpu/navi10: add OD support for restoring default table

2020-01-25 Thread Alex Deucher
Was missing before. Bug: https://gitlab.freedesktop.org/drm/amd/issues/1020 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_pp