Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Felix Kuehling
On 17-03-29 11:22 AM, Christian König wrote: > Am 29.03.2017 um 16:46 schrieb Michel Dänzer: >> On 29/03/17 11:32 PM, Felix Kuehling wrote: >>> On 17-03-29 02:52 AM, Christian König wrote: Please clean that up and also remove all those WARN_ON(), we don't want to spam the system log with

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Christian König
Am 29.03.2017 um 16:46 schrieb Michel Dänzer: On 29/03/17 11:32 PM, Felix Kuehling wrote: On 17-03-29 02:52 AM, Christian König wrote: Please clean that up and also remove all those WARN_ON(), we don't want to spam the system log with backtraces like this. I disagree. When you see the

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Michel Dänzer
On 29/03/17 11:32 PM, Felix Kuehling wrote: > On 17-03-29 02:52 AM, Christian König wrote: >> >> Please clean that up and also remove all those WARN_ON(), we don't >> want to spam the system log with backtraces like this. > > I disagree. When you see the backtraces from WARN_ONs in >

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Felix Kuehling
(or masking of high bits) could be >>> moved up >>> to the caller. >>> >>> Regards, >>>Felix >>> >>> >>> -- >>> F e l i x K u e h l i n g >>> SMTS Software Development Engineer | Vertical Workstati

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Zhang, Jerry (Junwei)
vid(ChunMing) *Cc:* Deucher, Alexander; Russell, Kent *Subject:* Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs On 03/29/2017 09:00 AM, Felix Kuehling wrote: Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_level

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-29 Thread Christian König
ussell, Kent *Subject:* Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs On 03/29/2017 09:00 AM, Felix Kuehling wrote: Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_levels. Add WARN_ONs if page tables

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-28 Thread Kuehling, Felix
: Deucher, Alexander; Russell, Kent Subject: Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs On 03/29/2017 09:00 AM, Felix Kuehling wrote: > Fix the start/end address calculation for address ranges that span > multiple page directories in amdgpu_vm_alloc_levels. >

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-28 Thread Zhang, Jerry (Junwei)
On 03/29/2017 09:00 AM, Felix Kuehling wrote: Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_levels. Add WARN_ONs if page tables aren't found. Otherwise the page table update would just fail silently. Signed-off-by: Felix

[PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

2017-03-28 Thread Felix Kuehling
Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_levels. Add WARN_ONs if page tables aren't found. Otherwise the page table update would just fail silently. Signed-off-by: Felix Kuehling ---