Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Christian König
rom: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2018年3月1日 17:39 To: Liu, Monk <monk@amd.com>; Koenig, Christian <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Liu, Monk
stian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Hi Monk, look at si_dma_stop() and/or other SDMA generation code. Regards, Christian. Am 01.03.2018 um 10:37 schrieb Liu, Monk: > Hi Christian > >

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Christian König
edesktop.org Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer amdgpu_evict_flags() and amdgpu_bo_move() needs to know if the SDMA ring is available during suspend/resume. As long as we are in gpu reset, we don't return error when ring not ready, cuz eventual

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Liu, Monk
md-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu, Monk Sent: 2018年3月1日 16:52 To: Koenig, Christian <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer > amdgpu_evict_flags() and amdgpu_

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Christian König
<christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer amdgpu_evict_flags() and amdgpu_bo_move() needs to know if the SDMA ring is available during suspend/resume. As long as we are in gpu reset, we

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Liu, Monk
:52 To: Koenig, Christian <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer > amdgpu_evict_flags() and amdgpu_bo_move() needs to know if the SDMA ring is > available during suspend/resume. A

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Liu, Monk
s your concern ? /Monk -Original Message- From: Koenig, Christian Sent: 2018年3月1日 16:41 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer > If we are in gpu rest stage, we c

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Christian König
rom: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2018年3月1日 16:16 To: Liu, Monk <monk@amd.com>; Koenig, Christian <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Liu, Monk
2018年2月28日 20:46 > To: Liu, Monk <monk....@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready > for fill_buffer > > Good point, but in this case we need some other handling. > > Please change the test to u

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-03-01 Thread Christian König
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2018年2月28日 20:24 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Am 28.02.2018 um 08:21 schrieb Monk Liu: because thi

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-28 Thread Liu, Monk
is such case ? /Monk -Original Message- From: Koenig, Christian Sent: 2018年2月28日 20:46 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Good point, but in this case we need some other

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-28 Thread Christian König
mer...@gmail.com] Sent: 2018年2月28日 20:24 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Am 28.02.2018 um 08:21 schrieb Monk Liu: because this time SDMA may under GPU RESET so its ring->ready

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-28 Thread Liu, Monk
<christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Because when SDMA was hang by like process A, and meanwhile another process B is already running into the code of fill_buffer() So just let proces

RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-28 Thread Liu, Monk
<monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Am 28.02.2018 um 08:21 schrieb Monk Liu: > because this time SDMA may under GPU RESET so its ring->ready may not > true, keep going and GPU scheduler

Re: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-28 Thread Christian König
Am 28.02.2018 um 08:21 schrieb Monk Liu: because this time SDMA may under GPU RESET so its ring->ready may not true, keep going and GPU scheduler will reschedule this job if it failed. give a warning on copy_buffer when go through direct_submit while ring->ready is false NAK, that test has

[PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-27 Thread Monk Liu
because this time SDMA may under GPU RESET so its ring->ready may not true, keep going and GPU scheduler will reschedule this job if it failed. give a warning on copy_buffer when go through direct_submit while ring->ready is false Change-Id: Ife6cd55e0e843d99900e5bed5418499e88633685