Re: [PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-22 Thread Zhang, Jerry(Junwei)
On 10/22/2018 08:35 PM, Christian König wrote: Am 22.10.18 um 08:45 schrieb Zhang, Jerry(Junwei): A question in ttm_bo.c [SNIP]     int ttm_bo_device_release(struct ttm_bo_device *bdev)   { @@ -1623,18 +1620,25 @@ int ttm_bo_device_release(struct ttm_bo_device *bdev)

Re: [PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-22 Thread Christian König
Am 22.10.18 um 08:45 schrieb Zhang, Jerry(Junwei): A question in ttm_bo.c [SNIP]     int ttm_bo_device_release(struct ttm_bo_device *bdev)   { @@ -1623,18 +1620,25 @@ int ttm_bo_device_release(struct ttm_bo_device *bdev) drm_vma_offset_manager_destroy(>vma_manager);   +    if (!ret) +   

Re: [PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-22 Thread Zhang, Jerry(Junwei)
A question for ttm_bo.c On 10/20/2018 12:41 AM, Christian König wrote: Make sure that the global BO state is always correctly initialized. This allows removing all the device code to initialize it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59

Re: [PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-22 Thread Zhang, Jerry(Junwei)
A question in ttm_bo.c On 10/20/2018 12:41 AM, Christian König wrote: Make sure that the global BO state is always correctly initialized. This allows removing all the device code to initialize it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59

[PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-19 Thread Christian König
Make sure that the global BO state is always correctly initialized. This allows removing all the device code to initialize it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1