Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-12 Thread Christian König
Am 12.05.2017 um 02:34 schrieb Dave Airlie: From: Dave Airlie This creates a new command submission chunk for amdgpu to add in and out sync objects around the submission. Sync objects are managed via the drm syncobj ioctls. The command submission interface is enhanced

Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-11 Thread Andres Rodriguez
The series looks ok to me so far, just the minor rebase nit on the first patch. Let me take an look again tomorrow morning since it is 1am and I might've missed something. Regards, Andres On 2017-05-11 08:34 PM, Dave Airlie wrote: From: Dave Airlie This creates a new

Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-11 Thread Dave Airlie
On 12 May 2017 at 13:34, zhoucm1 wrote: > 1. generally, functions in amdgpu_cs.c should be with amdgpu_cs_ as prefix. Okay I've fixed this and previous patch up locally. > 2. If I'm not wrong to your proposal, SYNCOBJ_IN is to semaphore wait while > SYNCOBJ_OUT is to

Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-11 Thread zhoucm1
1. generally, functions in amdgpu_cs.c should be with amdgpu_cs_ as prefix. 2. If I'm not wrong to your proposal, SYNCOBJ_IN is to semaphore wait while SYNCOBJ_OUT is to semaphore signal. SYNCOBJ_IN/OUT both are based on command submission ioctl, that means user space must generate CS when

[PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-11 Thread Dave Airlie
From: Dave Airlie This creates a new command submission chunk for amdgpu to add in and out sync objects around the submission. Sync objects are managed via the drm syncobj ioctls. The command submission interface is enhanced with two new chunks, one for syncobj pre

[PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-04-25 Thread Dave Airlie
From: Dave Airlie This creates a new command submission chunk for amdgpu to add in and out sync objects around the submission. Sync objects are managed via the drm syncobj ioctls. The command submission interface is enhanced with two new chunks, one for syncobj pre