RE: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Zeng, Oak
That is good idea. Will do it. thanks, Oak From: Deucher, Alexander Sent: Monday, November 26, 2018 11:02 AM To: Zeng, Oak ; Alex Deucher Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization Maybe it would be better to add

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Deucher, Alexander
: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization Ah, ok. no problem. Alex From: amd-gfx on behalf of Zeng, Oak Sent: Monday, November 26, 2018 10:31:04 AM To: Alex Deucher Cc: amd-gfx

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Deucher, Alexander
Ah, ok. no problem. Alex From: amd-gfx on behalf of Zeng, Oak Sent: Monday, November 26, 2018 10:31:04 AM To: Alex Deucher Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization Yes, that

RE: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-26 Thread Zeng, Oak
ter version, I moved calling of *_doorbell_index_init to the top of amdgpu_device_doorbell_init. thanks, Oak -Original Message- From: Alex Deucher Sent: Sunday, November 25, 2018 1:43 PM To: Zeng, Oak Subject: Fwd: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initializat

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-21 Thread Alex Deucher
On Wed, Nov 21, 2018 at 5:00 PM Oak Zeng wrote: > > Change-Id: I2f004bbbe2565035460686f4fc16e86b77a2a9b5 > Signed-off-by: Oak Zeng > Suggested-by: Felix Kuehling > Suggested-by: Alex Deucher I think it would be cleaner to call this in the soc files directly (cik.c, vi.c, soc15.c in the set_ip_

[PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-21 Thread Oak Zeng
Change-Id: I2f004bbbe2565035460686f4fc16e86b77a2a9b5 Signed-off-by: Oak Zeng Suggested-by: Felix Kuehling Suggested-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gp

Re: [PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-21 Thread Alex Deucher
On Wed, Nov 21, 2018 at 10:52 AM Oak Zeng wrote: > > Change-Id: I2f004bbbe2565035460686f4fc16e86b77a2a9b5 > Signed-off-by: Oak Zeng > Suggested-by: Felix Kuehling > Suggested-by: Alex Deucher I think it would be cleaner to add this to the *_set_ip_blocks() functions in cik.c, vi.c, and soc15.c

[PATCH 5/7] drm/amdgpu: Call doorbell index init on device initialization

2018-11-21 Thread Oak Zeng
Change-Id: I2f004bbbe2565035460686f4fc16e86b77a2a9b5 Signed-off-by: Oak Zeng Suggested-by: Felix Kuehling Suggested-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gp