Re: [PATCH 5/8] drm/amdgpu: new VM update backends

2019-03-25 Thread Kuehling, Felix
On 2019-03-25 7:38 a.m., Christian König wrote: > Am 20.03.19 um 12:57 schrieb Kuehling, Felix: >> As far as I can tell, the whole series is a small cleanup and big >> refactor to enable CPU clearing of PTs without a lot of ugliness or code >> duplication. > > It's a bit more than that. Key point

Re: [PATCH 5/8] drm/amdgpu: new VM update backends

2019-03-25 Thread Christian König
Am 20.03.19 um 12:57 schrieb Kuehling, Felix: As far as I can tell, the whole series is a small cleanup and big refactor to enable CPU clearing of PTs without a lot of ugliness or code duplication. It's a bit more than that. Key point is that I can now easily add a parameter for direct

Re: [PATCH 5/8] drm/amdgpu: new VM update backends

2019-03-20 Thread Kuehling, Felix
As far as I can tell, the whole series is a small cleanup and big refactor to enable CPU clearing of PTs without a lot of ugliness or code duplication. It looks good to me. I haven't reviewed all the moved SDMA update code to make sure it all works correctly, but at least the prepare and

[PATCH 5/8] drm/amdgpu: new VM update backends

2019-03-19 Thread Christian König
Separate out all functions for SDMA and CPU based page table updates into separate backends. This way we can keep most of the complexity of those from the core VM code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +-