Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-11-02 Thread Marek Olšák
On Fri, Nov 2, 2018 at 3:39 AM Koenig, Christian wrote: > Am 31.10.18 um 23:12 schrieb Marek Olšák: > > On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian < > christian.koe...@amd.com> wrote: > >> Am 30.10.18 um 16:59 schrieb Michel Dänzer: >> > On 2018-10-30 4:52 p.m., Marek Olšák wrote: >> >> On

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-11-02 Thread Koenig, Christian
Am 31.10.18 um 23:12 schrieb Marek Olšák: On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian mailto:christian.koe...@amd.com>> wrote: Am 30.10.18 um 16:59 schrieb Michel Dänzer: > On 2018-10-30 4:52 p.m., Marek Olšák wrote: >> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák >> mailto:mar...@gmail.com>>

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-31 Thread Marek Olšák
On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian wrote: > Am 30.10.18 um 16:59 schrieb Michel Dänzer: > > On 2018-10-30 4:52 p.m., Marek Olšák wrote: > >> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: > >>> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer > wrote: > >>> > On 2018-10-29 10:

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-31 Thread Koenig, Christian
Am 30.10.18 um 16:59 schrieb Michel Dänzer: > On 2018-10-30 4:52 p.m., Marek Olšák wrote: >> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: >>> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: >>> On 2018-10-29 10:15 p.m., Marek Olšák wrote: > You and I discussed this extensively in

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Michel Dänzer
On 2018-10-30 4:52 p.m., Marek Olšák wrote: > On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: >> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: >> >>> On 2018-10-29 10:15 p.m., Marek Olšák wrote: You and I discussed this extensively internally a while ago. It's >>> expected and co

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Marek Olšák
On Tue, Oct 30, 2018, 11:52 AM Marek Olšák wrote: > > > On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: > >> >> >> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: >> >>> On 2018-10-29 10:15 p.m., Marek Olšák wrote: >>> > You and I discussed this extensively internally a while ago. It's >>>

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Marek Olšák
On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: > > > On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: > >> On 2018-10-29 10:15 p.m., Marek Olšák wrote: >> > You and I discussed this extensively internally a while ago. It's >> expected >> > and correct behavior. Mesa doesn't unmap some buffe

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Marek Olšák
On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: > On 2018-10-29 10:15 p.m., Marek Olšák wrote: > > You and I discussed this extensively internally a while ago. It's > expected > > and correct behavior. Mesa doesn't unmap some buffers and never will. > > It doesn't need to keep mapping the same

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Koenig, Christian
Am 30.10.18 um 09:20 schrieb Michel Dänzer: > On 2018-10-29 10:15 p.m., Marek Olšák wrote: >> You and I discussed this extensively internally a while ago. It's expected >> and correct behavior. Mesa doesn't unmap some buffers and never will. Ah! Now I at least remember what issue that one was good

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-30 Thread Michel Dänzer
On 2018-10-29 10:15 p.m., Marek Olšák wrote: > You and I discussed this extensively internally a while ago. It's expected > and correct behavior. Mesa doesn't unmap some buffers and never will. It doesn't need to keep mapping the same buffer over and over again though, does it? -- Earthling Mic

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-29 Thread Marek Olšák
You and I discussed this extensively internally a while ago. It's expected and correct behavior. Mesa doesn't unmap some buffers and never will. Marek On Wed, Oct 24, 2018 at 3:45 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > That looks really ugly to me. Mapping the same BO so

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-29 Thread Marek Olšák
On Tue, Oct 23, 2018 at 10:38 PM Zhang, Jerry(Junwei) wrote: > On 10/24/18 3:07 AM, Marek Olšák wrote: > > From: Marek Olšák > > We need commit log and sign-off here. > > BTW, have you encounter any issue about that? > I don't know what you mean. I'm pretty sure that a sign-off is not needed fo

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-24 Thread Christian König
That looks really ugly to me. Mapping the same BO so often is illegal and should be handled as error. Otherwise we will never be able to cleanly recover from a GPU lockup with lost state by reloading the client library. Christian. Am 23.10.18 um 21:07 schrieb Marek Olšák: From: Marek Olšák

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-23 Thread Zhang, Jerry(Junwei)
On 10/24/18 3:07 AM, Marek Olšák wrote: From: Marek Olšák We need commit log and sign-off here. BTW, have you encounter any issue about that? --- amdgpu/amdgpu_bo.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgp

[PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-23 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu_bo.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index c0f42e81..81f8a5f7 100644 --- a/amdgpu/amdgpu_bo.c +++ b/amdgpu/amdgpu_bo.c @@ -22,20 +22,21 @@ * */ #include #