Re: [PATCH v1 01/14] ext4/xfs: add page refcount helper

2021-08-25 Thread Darrick J. Wong
On Tue, Aug 24, 2021 at 10:48:15PM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > >

Re: [PATCH v1 01/14] ext4/xfs: add page refcount helper

2021-08-25 Thread Theodore Ts'o
On Tue, Aug 24, 2021 at 10:48:15PM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > >

Re: [PATCH v1 01/14] ext4/xfs: add page refcount helper

2021-08-25 Thread Christoph Hellwig
On Tue, Aug 24, 2021 at 10:48:15PM -0500, Alex Sierra wrote: > Signed-off-by: Ralph Campbell > Signed-off-by: Alex Sierra > Reviewed-by: Christoph Hellwig > --- > v3: > [AS]: rename dax_layout_is_idle_page func to dax_page_unused > > v4: > [AS]: This ref count functionality was missing on

[PATCH v1 01/14] ext4/xfs: add page refcount helper

2021-08-24 Thread Alex Sierra
From: Ralph Campbell There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ralph Campbell Signed-off-by: Alex Sierra Reviewed-by: Christoph