Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2023-06-08 Thread Lucas Stach
Andrey > > Cc: Alex Deucher ; Chen, JingWen > ; Maling list - DRI developers > ; amd-gfx list > ; Koenig, Christian > Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." > > [AMD Official Use Only] > > Hi Daniel > > &

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-07 Thread Christian König
Am 07.09.21 um 10:47 schrieb Daniel Vetter: [SNIP] If we embed it, then I think it should start existing latest from drm_sched_job_arm. Maybe not yet initialized, but at least allocated. So the right thing to do here is to have the hw fence as a pointer in struct drm_sched_job. And check in

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-07 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 11:36:34AM -0400, Andrey Grodzovsky wrote: > > On 2021-09-02 10:28 a.m., Daniel Vetter wrote: > > On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Andrey Grodzovsky
On 2021-09-02 10:28 a.m., Daniel Vetter wrote: On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote:

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Daniel Vetter
On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > > > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-31 Thread Andrey Grodzovsky
On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: On 2021-08-19 5:30 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote:

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-31 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel Vetter wrote: > > > On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-18 10:42 a.m.,

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-26 Thread Daniel Vetter
On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-19 5:30 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:42 a.m., Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-26 Thread Daniel Vetter
gt; earliest > > -* job extracted. > > -*/ > > - list_add(>list, >pending_list); > > - > > - /* > > * Iterate the job list from later to earlier one and either > > deactive > >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-24 Thread Andrey Grodzovsky
--- -Original Message- From: Grodzovsky, Andrey Sent: Friday, August 20, 2021 10:07 PM To: Liu, Monk ; Daniel Vetter ; Koenig, Christian Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list Subject: Re: [PATCH v2] Revert "drm/scheduler: A

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-24 Thread Liu, Monk
-- -Original Message- From: Grodzovsky, Andrey Sent: Friday, August 20, 2021 10:07 PM To: Liu, Monk ; Daniel Vetter ; Koenig, Christian Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list Subject: Re: [PATCH v2] Revert "drm/scheduler: Avoi

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Andrey Grodzovsky
Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." [AMD Official Use Only] Hi Daniel Why can't we stop the scheduler thread first, so that there's guaranteed no race? I've recently had a lot of discussions with panfrost folks about their reset that spa

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Andrey Grodzovsky
Maling list - DRI developers ; amd-gfx list ; Liu, Monk ; Koenig, Christian Subject: Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Jingwen Chen
ore team > > -- > > > > -Original Message- > > From: Liu, Monk > > Sent: Thursday, August 19, 2021 6:26 PM > > To: Daniel Vetter ; Grodzovsky, Andrey > > > > Cc: Alex Deucher ; Chen, JingWen >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Christian König
Message- From: Liu, Monk Sent: Thursday, August 19, 2021 6:26 PM To: Daniel Vetter ; Grodzovsky, Andrey Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Koenig, Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job.&q

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Liu, Monk
, 2021 6:26 PM To: Daniel Vetter ; Grodzovsky, Andrey Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Koenig, Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." [AMD Official Use Only] Hi Daniel >> W

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Andrey Grodzovsky
On 2021-08-19 5:30 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18,

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Liu, Monk
- DRI developers ; amd-gfx list ; Liu, Monk ; Koenig, Christian Subject: Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-18 10:42 a.m., Daniel Vetter wrote: > > On Wed

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-18 10:42 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:32 a.m., Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 10:26:25AM -0400,

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Daniel Vetter
s > > -------------- > Monk Liu | Cloud-GPU Core team > -- > > -Original Message- > From: Daniel Vetter > Sent: Wednesday, August 18, 2021 10:43 PM > To: Grodzovsky, Andrey > Cc: Daniel Vetter ;

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Liu, Monk
ud-GPU Core team -- -Original Message- From: Daniel Vetter Sent: Wednesday, August 18, 2021 10:43 PM To: Grodzovsky, Andrey Cc: Daniel Vetter ; Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Liu, Monk ; Koenig, Chri

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-18 10:32 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:02 a.m., Alex Deucher wrote: > > > > > > > + dri-devel > > > > > > > > Since

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: > On 2021-08-18 10:02 a.m., Alex Deucher wrote: > > > + dri-devel > > > > Since scheduler is a shared component, please add dri-devel on all > > scheduler patches. > > > > On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: > >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:02:06AM -0400, Alex Deucher wrote: > + dri-devel > > Since scheduler is a shared component, please add dri-devel on all > scheduler patches. Do we need a MAINTAINRS entry specifically for this, or just oversight? > On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote:

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: [Why] for bailing job, this commit will delete it from pending list thus the bailing job will

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Alex Deucher
+ dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: > > [Why] > for bailing job, this commit will delete it from pending list thus the > bailing job will never have a chance to be resubmitted even

[PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Jingwen Chen
[Why] for bailing job, this commit will delete it from pending list thus the bailing job will never have a chance to be resubmitted even in advance tdr mode. [How] after embeded hw_fence into amdgpu_job is done, the race condition that this commit tries to work around is completely solved.So