Re: [PATCH v2] drm/amd/display: Use long for signed error code checks in commit planes

Am 02.05.19 um 15:14 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we

[PATCH v2] drm/amd/display: Use long for signed error code checks in commit planes

[Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we check <= 0. [How] Make 'r' a long in commit planes so