Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-14 Thread Alex Deucher
On Thu, Mar 10, 2022 at 9:32 PM Lang Yu wrote: > > On 03/10/ , Christian König wrote: > > Ok, thanks. > > > > Lang is that case your patch should work fine. > > > > Just add another patch with a check for the encode case to reject any CS > > with TMZ buffers in it. > > Only VCN decode ring is

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-10 Thread Christian König
Ok, thanks. Lang is that case your patch should work fine. Just add another patch with a check for the encode case to reject any CS with TMZ buffers in it. Thanks, Christian. Am 10.03.22 um 15:17 schrieb Leo Liu: No need for encode. Encrypting uses TEE/TA to convert clear bitstream to

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-10 Thread Leo Liu
No need for encode. Encrypting uses TEE/TA to convert clear bitstream to encrypted bitstream, and has nothing to do with VCN encode and tmz. Regards, Leo On 2022-03-10 04:53, Christian König wrote: Leo you didn't answered the question if we need TMZ for encode as well. Regards, Christian.

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-10 Thread Christian König
Leo you didn't answered the question if we need TMZ for encode as well. Regards, Christian. Am 10.03.22 um 09:45 schrieb Lang Yu: Ping. On 03/08/ , Leo Liu wrote: On 2022-03-08 11:18, Leo Liu wrote: On 2022-03-08 04:16, Christian König wrote: Am 08.03.22 um 09:06 schrieb Lang Yu: On

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-08 Thread James Zhu
+BoYuan I am not sure if we need add ENCRYPT check when allocate surface if is supposed to be TMZ protected . For example: VAStatus *vlVaHandleSurfaceAllocate*(vlVaDriver *drv, vlVaSurface *surface,   struct pipe_video_buffer *templat,   const

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-08 Thread Leo Liu
On 2022-03-08 11:18, Leo Liu wrote: On 2022-03-08 04:16, Christian König wrote: Am 08.03.22 um 09:06 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 08:33 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 04:39 schrieb Lang Yu: It is a hardware issue

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-08 Thread Leo Liu
On 2022-03-08 04:16, Christian König wrote: Am 08.03.22 um 09:06 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 08:33 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 04:39 schrieb Lang Yu: It is a hardware issue that VCN can't handle a GTT backing

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-08 Thread Alex Deucher
On Tue, Mar 8, 2022 at 4:16 AM Christian König wrote: > > Am 08.03.22 um 09:06 schrieb Lang Yu: > > On 03/08/ , Christian König wrote: > >> Am 08.03.22 um 08:33 schrieb Lang Yu: > >>> On 03/08/ , Christian König wrote: > Am 08.03.22 um 04:39 schrieb Lang Yu: > > It is a hardware issue

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-08 Thread Christian König
Am 08.03.22 um 09:06 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 08:33 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 04:39 schrieb Lang Yu: It is a hardware issue that VCN can't handle a GTT backing stored TMZ buffer on Raven. Move such a TMZ

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-07 Thread Christian König
Am 08.03.22 um 08:33 schrieb Lang Yu: On 03/08/ , Christian König wrote: Am 08.03.22 um 04:39 schrieb Lang Yu: It is a hardware issue that VCN can't handle a GTT backing stored TMZ buffer on Raven. Move such a TMZ buffer to VRAM domain before command submission. v2: - Use

[PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-07 Thread Lang Yu
It is a hardware issue that VCN can't handle a GTT backing stored TMZ buffer on Raven. Move such a TMZ buffer to VRAM domain before command submission. v2: - Use patch_cs_in_place callback. Suggested-by: Christian König Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 68