Re: [PATCH v2 02/10] drm: Include where needed

2023-01-13 Thread Ville Syrjälä
On Fri, Jan 13, 2023 at 04:11:48PM +0100, Sam Ravnborg wrote: > Hi Ville, > On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > > Include in source files that need it. Some of DRM's > > > source code gets OF

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-13 Thread Sam Ravnborg
Hi Ville, On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > Include in source files that need it. Some of DRM's > > source code gets OF header via drm_crtc_helper.h and , > > which can leed to unnecessary

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-11 Thread Ville Syrjälä
On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > Include in source files that need it. Some of DRM's > source code gets OF header via drm_crtc_helper.h and , > which can leed to unnecessary recompilation. > > In drm_modes.c, add a comment on the reason for still including > .

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-11 Thread Liviu Dudau
On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > Include in source files that need it. Some of DRM's > source code gets OF header via drm_crtc_helper.h and , > which can leed to unnecessary recompilation. > > In drm_modes.c, add a comment on the reason for still including > .

[PATCH v2 02/10] drm: Include where needed

2023-01-11 Thread Thomas Zimmermann
Include in source files that need it. Some of DRM's source code gets OF header via drm_crtc_helper.h and , which can leed to unnecessary recompilation. In drm_modes.c, add a comment on the reason for still including . The header file is required to get KHZ2PICOS(). The macro is part of the UAPI