Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Marek Olšák
;>>> > >>>> > >>>> > >>>> When we started this patch series, the workload hint was a part of > the ctx_flag only, > >>>> > >>>> But we changed that after the design review, to make it more like how > we are handling PSTA

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Alex Deucher
gt;> >>>> >>>> When we started this patch series, the workload hint was a part of the >>>> ctx_flag only, >>>> >>>> But we changed that after the design review, to make it more like how we >>>> are handling PSTATE. >>>>

RE: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Sharma, Shashank
] drm/amdgpu: add UAPI for workload hints to ctx ioctl Well that sounds like being able to optionally set it after context creation is actually the right approach. VA-API could set it as soon as we know that this is a video codec application. Vulkan can set it depending on what features are used

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Marek Olšák
nt was a part of the >>> ctx_flag only, >>> >>> But we changed that after the design review, to make it more like how we >>> are handling PSTATE. >>> >>> >>> >>> Details: >>> >>> https://patchwork.freed

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Christian König
to:amaranath.somalapu...@amd.com>; Koenig, Christian <mailto:christian.koe...@amd.com> *Subject:* Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl I think we should do it differently because this interface will be mostly u

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Marek Olšák
ged that after the design review, to make it more like how we >> are handling PSTATE. >> >> >> >> Details: >> >> https://patchwork.freedesktop.org/patch/496111/ >> >> >> >> Regards >> >> Shashank >> >> >> >> *

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Christian König
deuc...@amd.com>; Somalapuram, Amaranath <mailto:amaranath.somalapu...@amd.com>; Koenig, Christian <mailto:christian.koe...@amd.com> *Subject:* Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl I think we should do it differently because this inter

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-22 Thread Marek Olšák
etails: > > https://patchwork.freedesktop.org/patch/496111/ > > > > Regards > > Shashank > > > > *From:* Marek Olšák > *Sent:* 21 March 2023 04:05 > *To:* Sharma, Shashank > *Cc:* amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Somalapuram,

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-21 Thread Christian König
*To:* Sharma, Shashank *Cc:* amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian *Subject:* Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl I think we should do it differently because this interface will be mostly unused

RE: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-21 Thread Sharma, Shashank
: Marek Olšák Sent: 21 March 2023 04:05 To: Sharma, Shashank Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl I think we should do it differently because

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-20 Thread Marek Olšák
I think we should do it differently because this interface will be mostly unused by open source userspace in its current form. Let's set the workload hint in drm_amdgpu_ctx_in::flags, and that will be immutable for the lifetime of the context. No other interface is needed. Marek On Mon, Sep 26,

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2022-09-27 Thread Felix Kuehling
Am 2022-09-26 um 17:40 schrieb Shashank Sharma: Allow the user to specify a workload hint to the kernel. We can use these to tweak the dpm heuristics to better match the workload for improved performance. V3: Create only set() workload UAPI (Christian) Signed-off-by: Alex Deucher

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2022-09-27 Thread Christian König
Am 26.09.22 um 23:40 schrieb Shashank Sharma: Allow the user to specify a workload hint to the kernel. We can use these to tweak the dpm heuristics to better match the workload for improved performance. V3: Create only set() workload UAPI (Christian) Signed-off-by: Alex Deucher Signed-off-by:

[PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2022-09-26 Thread Shashank Sharma
Allow the user to specify a workload hint to the kernel. We can use these to tweak the dpm heuristics to better match the workload for improved performance. V3: Create only set() workload UAPI (Christian) Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma ---