Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:54 AM, Lazar, Lijo wrote: On 9/30/2022 2:52 PM, Sharma, Shashank wrote: On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29,

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Lazar, Lijo
On 9/30/2022 2:52 PM, Sharma, Shashank wrote: On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Lazar, Lijo
On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Lazar, Lijo
On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Lazar, Lijo
On 9/29/2022 11:37 PM, Felix Kuehling wrote: On 2022-09-29 07:10, Lazar, Lijo wrote: On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue,

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Alex Deucher
On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: > > > > On 9/29/2022 7:30 PM, Sharma, Shashank wrote: > > > > > > On 9/29/2022 3:37 PM, Lazar, Lijo wrote: > >> To be clear your understanding - > >> > >> Nothing is automatic in PMFW. PMFW picks a priority based on the > >> actual mask sent by

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Felix Kuehling
On 2022-09-29 07:10, Lazar, Lijo wrote: On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 4:14 PM, Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the actual mask sent by driver. Assuming lower bits

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Lazar, Lijo
On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the actual mask sent by driver. Assuming lower bits corresponds to highest priority - If driver sends a

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in PMFW. PMFW picks a priority based on the actual mask sent by driver. Assuming lower bits corresponds to highest priority - If driver sends a mask with Bit3 and Bit 0 set, PMFW will chose

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Lazar, Lijo
On 9/29/2022 6:50 PM, Sharma, Shashank wrote: On 9/29/2022 1:10 PM, Lazar, Lijo wrote: On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/29/2022 1:10 PM, Lazar, Lijo wrote: On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Lazar, Lijo
On 9/29/2022 2:18 PM, Sharma, Shashank wrote: On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-29 Thread Sharma, Shashank
On 9/28/2022 11:51 PM, Alex Deucher wrote: On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma,

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Alex Deucher
On Wed, Sep 28, 2022 at 4:57 AM Sharma, Shashank wrote: > > > > On 9/27/2022 10:40 PM, Alex Deucher wrote: > > On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank > > wrote: > >> > >> > >> > >> On 9/27/2022 5:23 PM, Felix Kuehling wrote: > >>> Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: >

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Sharma, Shashank
Small correction, On 9/28/2022 10:56 AM, Sharma, Shashank wrote: On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Sharma, Shashank
On 9/27/2022 10:40 PM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-28 Thread Lazar, Lijo
On 9/28/2022 2:10 AM, Alex Deucher wrote: On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Alex Deucher
On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank wrote: > > > > On 9/27/2022 5:23 PM, Felix Kuehling wrote: > > Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: > >> Hello Felix, > >> > >> Thank for the review comments. > >> > >> On 9/27/2022 4:48 PM, Felix Kuehling wrote: > >>> Am 2022-09-27 um

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Sharma, Shashank
On 9/27/2022 5:23 PM, Felix Kuehling wrote: Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Felix Kuehling
Am 2022-09-27 um 10:58 schrieb Sharma, Shashank: Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch switches the GPU workload mode to/from compute

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Sharma, Shashank
Hello Felix, Thank for the review comments. On 9/27/2022 4:48 PM, Felix Kuehling wrote: Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload.

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Felix Kuehling
Am 2022-09-27 um 02:12 schrieb Christian König: Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Feel free to add my acked-by, but

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-27 Thread Christian König
Am 26.09.22 um 23:40 schrieb Shashank Sharma: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Feel free to add my acked-by, but Felix should probably take a look as well.

[PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-26 Thread Shashank Sharma
This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git