Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Driver specific behavior. > > > > TBH this is still

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Simon Ser
On Friday, May 26th, 2023 at 18:27, Sebastian Wick wrote: > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > + * Driver specific behavior. > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > + * Driver specific behavior. > > TBH this is still confusing me. Is DEFAULT really just driver specific > behavior?

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Thu, May 25, 2023 at 9:18 PM Harry Wentland wrote: > > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" > -

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Pekka Paalanen
On Thu, 25 May 2023 15:17:58 -0400 Harry Wentland wrote: > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" >

[PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-25 Thread Harry Wentland
From: Joshua Ashton To match the other enums, and add more information about these values. v2: - Specify where an enum entry comes from - Clarify DEFAULT and NO_DATA behavior - BT.2020 CYCC is "constant luminance" - correct type for BT.601 v4: - drop DP/HDMI clarifications that might