Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-15 Thread Bert Karwatzki
lo, Mario ; Kazlauskas, > > Nicholas > > ; Zhuo, Qingqing (Lillian) > > ; Scott Bruce ; Chris > > Hixon > > > > Subject: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on > > DCN20/DCN21 > > > > I just tested patch v5 applied to amd-stagin

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Alex Deucher
On Fri, Jan 14, 2022 at 1:47 PM Limonciello, Mario wrote: > > [Public] > > > > > > > > > > > > > > > >> I think the revert is fine once we figure out where we're missing > > > > >> calls to: > > > > >> > > > > >> .optimize_pwr_state = dcn21_optimize_pwr_state, > > > > >> .exit_o

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Limonciello, Mario
[Public] > > > > > > > > > > > >> I think the revert is fine once we figure out where we're missing > > > >> calls to: > > > >> > > > >> .optimize_pwr_state = dcn21_optimize_pwr_state, > > > >> .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > > > >> > > > >> These a

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Kazlauskas, Nicholas
[Public] > -Original Message- > From: Limonciello, Mario > Sent: January 14, 2022 10:38 AM > To: Chris Hixon ; Kazlauskas, Nicholas > ; amd-gfx@lists.freedesktop.org > Cc: Zhuo, Qingqing (Lillian) ; Scott Bruce > ; spassw...@web.de > Subject: RE: [PATCH v5] drm

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Limonciello, Mario
[AMD Official Use Only] > > > > > >> I think the revert is fine once we figure out where we're missing calls to: > >> > >> .optimize_pwr_state = dcn21_optimize_pwr_state, > >> .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > >> > >> These are already part of dc_link_

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-13 Thread Limonciello, Mario
, Nicholas ; Zhuo, Qingqing (Lillian) ; Scott Bruce ; Chris Hixon Subject: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21 I just tested patch v5 applied to amd-staging-drm-next (with HEAD 26c981e27e698c251ef3241f73ac846e66ad7fc3) and suspend and resume work fine. But as amd

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-13 Thread Bert Karwatzki
lo, Mario ; Kazlauskas, > > Nicholas > > ; Zhuo, Qingqing (Lillian) > > ; Scott Bruce ; Chris > > Hixon > > > > Subject: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on > > DCN20/DCN21 > > > > I just tested patch v5 applied to amd-stagin

[PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-11 Thread Bert Karwatzki
I just tested patch v5 applied to amd-staging-drm-next (with HEAD 26c981e27e698c251ef3241f73ac846e66ad7fc3) and suspend and resume work fine. But as amd-staging-drm-next is still based on linux-5.13 I had to replace the mediatek wlan driver by the version from linux-5.16.

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-11 Thread Limonciello, Mario
Subject: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on > DCN20/DCN21 > > I just tested patch v5 applied to amd-staging-drm-next (with HEAD > 26c981e27e698c251ef3241f73ac846e66ad7fc3) and suspend and resume work > fine. But as amd-staging-drm-next is still based on linux-5.13 I

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-07 Thread Limonciello, Mario
[AMD Official Use Only] > I think the revert is fine once we figure out where we're missing calls to: > > .optimize_pwr_state = dcn21_optimize_pwr_state, > .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > > These are already part of dc_link_detect, so I suspect ther

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-07 Thread Kazlauskas, Nicholas
web.de > Subject: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on > DCN20/DCN21 > Importance: High > > The WA from commit 2a50edbf10c8 ("drm/amd/display: Apply w/a for hard > hang > on HPD") and commit 1bd3bc745e7f ("drm/amd/display: Extend w/a for hard &g

[PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-07 Thread Mario Limonciello
The WA from commit 2a50edbf10c8 ("drm/amd/display: Apply w/a for hard hang on HPD") and commit 1bd3bc745e7f ("drm/amd/display: Extend w/a for hard hang on HPD to dcn20") causes a regression in s0ix where the system will fail to resume properly on many laptops. Pull the workarounds out to avoid tha