Re: [bug report] drm/amdgpu : Generate XGMI topology info from driver level

2019-01-04 Thread Liu, Shaoyun
It seems  patch d492c564  revert to this  original code otherwise we shouldn't get the warning . I can add ret =  -EINVAL for this. Regards shaoyun.liu On 2019-01-04 6:53 a.m., Dan Carpenter wrote: > Hello Shaoyun Liu, > > The patch fb30fc59a245: "drm/amdgpu : Generate XGMI topology info >

[bug report] drm/amdgpu : Generate XGMI topology info from driver level

2019-01-04 Thread Dan Carpenter
Hello Shaoyun Liu, The patch fb30fc59a245: "drm/amdgpu : Generate XGMI topology info from driver level" from Jun 27, 2018, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:117 amdgpu_xgmi_add_device() warn: missing error code here?