RE: 回复: 回复: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-19 Thread Lazar, Lijo
ary 19, 2021 10:45 PM To: Chen, Horace ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Xu, Feifei ; Wang, Kevin(Yang) ; Tuikov, Luben ; Deucher, Alexander ; Quan, Evan ; Koenig, Christian ; Liu, Monk ; Zhang, Hawking Subject: Re: 回复: 回复: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 r

Re: 回复: 回复: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-19 Thread Andrey Grodzovsky
Well, it shouldn't happen with the hive locked as I am browsing the code but then your code should reflect that and if you do fail to lock particular adev AFTER the hive is locked you should not silently break iteration but throw an error, WARN_ON or BUG_ON then. Or alternatively bail out with u

回复: 回复: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-19 Thread Chen, Horace
[AMD Official Use Only - Internal Distribution Only] OK, I understand. You mean one device in the hive may be locked up independently without locking up the whole hive. It could happen, I'll change my code. Thanks & Regards, Horace. 发件人: Grodzovsky, Andrey 发送时